Skip to content
Snippets Groups Projects

Remove drupal.tableheader library

1 unresolved thread

Closes #3439580

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dipak Yadav resolved all threads

    resolved all threads

  • Dipak Yadav added 1 commit

    added 1 commit

    • eb50d0e4 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Binoli Lalani added 1 commit

    added 1 commit

    Compare with previous version

  • Binoli Lalani added 24 commits

    added 24 commits

    • 0fe29bfd...36619bd1 - 16 commits from branch project:10.3.x
    • 3a64f216 - Remove drupal.tableheaders
    • 055e78cc - Add empty drupalSettings.
    • ddbe637c - Update deprecation message.
    • 49cf1260 - Un-deprecate the drupal.tableheader library.
    • 2046f659 - Add missing library dependency.
    • 44eb200a - Apply 1 suggestion(s) to 1 file(s)
    • 989b9545 - Issue #3439580: Remove drupal.tableheader library
    • 8ed1f1ea - Merge branch '3439580-remove-drupal.tableheader-library-10.3.x' of...

    Compare with previous version

  • Dipak Yadav added 8 commits

    added 8 commits

    Compare with previous version

  • Dipak Yadav added 1 commit

    added 1 commit

    • 1df1f4b9 - Add moved_files declaration for the library.

    Compare with previous version

  • Dipak Yadav resolved all threads

    resolved all threads

  • Dipak Yadav added 1 commit

    added 1 commit

    • f8b9a275 - Update override path in stable9.

    Compare with previous version

  • catch @catch started a thread on the diff
  • 753 753
    754 754 drupal.tableheader:
    755 755 version: VERSION
    756 js:
    757 misc/tableheader.js: {}
    758 dependencies:
    759 - core/jquery
    760 - core/drupal
    761 - core/drupalSettings
    762 - core/once
    763 - core/drupal.displace
    756 css:
    757 component:
    758 misc/components/sticky-header.module.css: { weight: -10 }
    759 moved_files:
    • Maintainer

      This should have a js entry for misc/tableheader.js: false too I think.

    • Do you mean under moved_files. I haven't seen that in any example in core.

      I have only seen false declaration for js/css files in overrides where it's mean to be removed by the override.

      Does false declaration under moved_files mean that file's being deleted?

    • @dipakmdhrm misc/tableheader.js: false typically means that it has been removed or deprecated.

      So yes, I think in this context, false implies that the misc/tableheader.js file has been removed or is no longer used in the context of the drupal.tableheader library.

      Edited by Sourojeet Paul
    • Please register or sign in to reply
  • Sourojeet Paul added 1 commit

    added 1 commit

    Compare with previous version

  • Dipak Yadav added 77 commits

    added 77 commits

    Compare with previous version

  • Dipak Yadav added 2 commits

    added 2 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading