The patch uploaded in comment 81. Allows grouping by HTML elements.
This patch appears to work on a local 11.x install.
Merge request reports
Activity
added 54 commits
- 69dbeb3d...1fdb704c - 44 earlier commits
- 573f8bdb - Issue #3439493 by mondrake: Change remaining Forum module test dataproviders to static
- 80ae8b09 - Issue #3420974 by andypost, quietone, dimitriskr, catch: Add testing wtih Maria DB 10.6
- f6b47c4d - Issue #3439647 by catch: Skip query string compression if zlib extension isn't available
- 988ca5ec - Issue #3427178 by mondrake, longwave: Replace calls to ::expectWarning*() from...
- 08ba59d1 - Issue #3437623 by alexpott, kim.pepper, sakthi_dev:...
- b168dc4f - Issue #3439829 by thebumik, dimitriskr, vensires: Fix Blocks tests that rely...
- 385db16c - Issue #3440087 by dww: Update CacheTagOperation enum to use UpperCamelCase
- 63784f22 - Issue #3000749 by amateescu, s_leu, dragos-dumi, tim.plunkett, jeremylichtman,...
- 2fa3c3e1 - Issue #3272629 by kelly.m.jacobs, alexpott, Abhijith S, imclean, heni_deepak,...
- aa3ac2b0 - Issue #3439446 by Gábor Hojtsy, nod_, ckrina, justafish: Promote Cristina...
Toggle commit listadded 10 commits
- 830d64e1 - Issue #3303557 by Binoli Lalani, quietone, catch, Tom Konda, smustgrave:...
- 8bc963c1 - Issue #3439800 by mstrelan: Standardize location of test modules
- 81a92603 - Issue #3439766 by markusVJH, quietone: Removed unused update test fixtures
- 72225dde - Issue #3440176 by mondrake: Change remaining Media module test dataproviders to static
- cf64c0c7 - Issue #3439893 by thebumik, vensires: Fix Layout Builder tests that rely on...
- 1e378338 - Issue #3440115 by mondrake: Change remaining File module test dataproviders to static
- 57b1ed3a - Issue #3440180 by mondrake: Fix wrong getStatus() call in MenuAccessTest
- 6110f7be - Issue #3440175 by mondrake:...
- fe1349ab - Revert "Issue #3439800 by mstrelan: Standardize location of test modules"
- 578cdbf5 - Issue #3422872 by kunal.sachdev, Wim Leers: Add validation constraints to contact.settings
Toggle commit listadded 65 commits
-
578cdbf5...c41bea2d - 64 commits from branch
project:11.x - 1251e3eb - Merge branch '11.x' of git.drupal.org:project/drupal into drupal-1383696-82
-
578cdbf5...c41bea2d - 64 commits from branch
274 290 return $options; 275 291 } 276 292 293 /** 294 * Retrieve labels from views configuration. changed this line in version 10 of the diff
274 290 return $options; 275 291 } 276 292 293 /** 294 * Retrieve labels from views configuration. 295 */ 296 public function getLabelElements() { 
@smustgrave return typehint and description added. Thinking this is what it should be based on other code examples and since $labelElements returns an array, but please chime in if this looks off to you. Thanks!
174 181 return $this->usesGrouping; 175 182 } 176 183 184 /** 185 * Returns the usesGroupingLabelElement property. 186 * 187 * @return bool 188 */ 189 public function usesGroupingLabelElement() { changed this line in version 9 of the diff
56 56 */ 57 57 protected $usesRowPlugin = FALSE; 58 58 59 /** 60 * Should grouping fields use a wrapping element tag. 61 * 62 * @var bool 63 */ 64 protected $usesGroupingLabelElement = FALSE; changed this line in version 8 of the diff
33 33 */ 34 34 protected $usesRowClass = TRUE; 35 35 36 /** 37 * Should grouping fields use a wrapping element tag. 38 * 39 * @var bool 40 */ 41 protected $usesGroupingLabelElement = TRUE; changed this line in version 7 of the diff
That is a good question. In StylePluginBase.php the GroupingLabelElement is set to false. Seeing your other comments, I think I need to make this be
protected bool $usesGroupingLabelElement = FALSE;
/**
- Should grouping fields use a wrapping element tag.
- @var bool */ protected $usesGroupingLabelElement = FALSE;
added 1 commit
- e52f5645 - fixes phpcs formatting flagged in StylePluginBase
added 206 commits
-
e52f5645...082f8910 - 197 commits from branch
project:11.x - 38a266e2 - The patch uploaded in comment 81. Allows grouping by HTML elements.
- 93c4f445 - Fixed two whitespace errors.
- 4b7a0596 - Fixed two whitespace errors.
- 048c80c6 - add bool param to function
- b5883e31 - add bool param to grouping label function
- af635451 - add bool param to grouping label function
- 9e29a2fe - identify bool param on protected label element functions
- af3762e4 - add return array typehint and description to getLabelElements
- eaf414b7 - fixes phpcs formatting flagged in StylePluginBase
Toggle commit list-
e52f5645...082f8910 - 197 commits from branch
added 75 commits
- eaf414b7...49ce0c0e - 65 earlier commits
- a77cbc57 - Issue #3443959: DialogRenderer::getTitleAsStringable() does not support all...
- 92ba71fe - Issue #3439923 by alexpott, longwave, thejimbirch, Wim Leers, phenaproxima,...
- 992e5a45 - Issue #3417066 by mondrake, longwave, larowlan, alexpott, catch: Upgrade...
- 02b4d49e - Issue #3444264 by andypost, alexpott, longwave: [PHP 8.4] ReflectionMethod...
- 6746c9c0 - Issue #3445791 by balsama, phenaproxima: Language module...
- 3edfd5fc - Issue #3445833 by catch: Performance test gitlab job is failing on 11.x
- d1d9e2bd - Issue #3444978 by catch, Berdir: UserAuth BC layer is not working for modules...
- b9d1a6d0 - Issue #3445788 by andypost: [PHP 8.4] Fix phpstan job for ContentModerationConfigureEntityTypesForm
- f1520f62 - Updated views-view-grid.html.twig to use grouping logic.
- 04d94666 - Updating core templates to match new views templates.
Toggle commit listadded 124 commits
-
04d94666...0a4f122f - 113 commits from branch
project:11.x - 1fc0725a - 1 earlier commit
- 6106bc13 - Fixed two whitespace errors.
- ec047954 - Fixed two whitespace errors.
- df35b91d - add bool param to function
- ca115a7e - add bool param to grouping label function
- 9521635d - add bool param to grouping label function
- c2ad351f - identify bool param on protected label element functions
- 28322e8a - add return array typehint and description to getLabelElements
- 46ce1614 - fixes phpcs formatting flagged in StylePluginBase
- 3c067458 - Updated views-view-grid.html.twig to use grouping logic.
- a49a0f0c - Updating core templates to match new views templates.
Toggle commit list-
04d94666...0a4f122f - 113 commits from branch
added 20 commits
-
a49a0f0c...4556add5 - 9 commits from branch
project:11.x - a941f12f - 1 earlier commit
- 99d06186 - Fixed two whitespace errors.
- 8b8ae641 - Fixed two whitespace errors.
- 6c7e7046 - add bool param to function
- c8c07901 - add bool param to grouping label function
- 14536643 - add bool param to grouping label function
- 7a29300f - identify bool param on protected label element functions
- 85793d39 - add return array typehint and description to getLabelElements
- d1c5a889 - fixes phpcs formatting flagged in StylePluginBase
- 10104305 - Updated views-view-grid.html.twig to use grouping logic.
- ad0f1b9f - Updating core templates to match new views templates.
Toggle commit list-
a49a0f0c...4556add5 - 9 commits from branch
Please register or sign in to reply