Skip to content
Snippets Groups Projects

improve update status email subject

Open quietone requested to merge issue/drupal-1818764:1818764-correct--improve into 11.x
2 unresolved threads

Closes #1818764

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jess
  • 404 $subject = t('Security release(s) available for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]);
    405 }
    406
    407 // If no subject yet then check for fetch failures. If all the reasons
    408 // are fetch failures the use the fetch subject.
    409 if (empty($subject)) {
    410 $fetch = array_filter($all_reasons, function ($item) {
    411 return $item > 0;
    412 });
    413 if (empty($fetch) && !empty($all_reasons)) {
    414 $subject = t('Failed to get release information for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]);
    415 }
    416 }
    417
    418 // If still no subject, then there are non-security updates and use the non-
    419 // security subject. Then update the subject in the existing message.
    • Comment on lines +418 to +419
      Maintainer
      Suggested change
      418 // If still no subject, then there are non-security updates and use the non-
      419 // security subject. Then update the subject in the existing message.
      418 // If the subject still has not been set, then there are only non-security
      419 // updates. Use the subject for non-security updates.
    • Pradhuman Jain changed this line in version 4 of the diff

      changed this line in version 4 of the diff

    • This one I'm 50/50 on but the last sentence "Then update the subject in the existing message." probably wasn't needed.

    • Please register or sign in to reply
  • 408 // are fetch failures the use the fetch subject.
    409 if (empty($subject)) {
    410 $fetch = array_filter($all_reasons, function ($item) {
    411 return $item > 0;
    412 });
    413 if (empty($fetch) && !empty($all_reasons)) {
    414 $subject = t('Failed to get release information for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]);
    415 }
    416 }
    417
    418 // If still no subject, then there are non-security updates and use the non-
    419 // security subject. Then update the subject in the existing message.
    420 if (empty($subject)) {
    421 $subject = t('New release(s) available for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]);
    422 }
    423 $message['subject'] .= $subject;
  • Jess
  • Pradhuman Jain added 1 commit

    added 1 commit

    • 7c880d4b - Issue #1818764 by xurizaemon, quietone, haydeniv, amitgoyal, smustgrave, xjm,...

    Compare with previous version

  • Dhruv Mittal added 1521 commits

    added 1521 commits

    Compare with previous version

  • Daniel Rodriguez added 211 commits

    added 211 commits

    • 05379fea...10a80a91 - 210 commits from branch project:11.x
    • 8d611611 - Issue # 1818764: Fixed conflicts after rebasing at file:...

    Compare with previous version

  • Daniel Rodriguez added 6 commits

    added 6 commits

    Compare with previous version

  • added 1 commit

    • f308ee46 - Issue # 1818764: Fixed some PHPCS and PHPSTAN issues reported by the pipeline jobs

    Compare with previous version

  • added 1 commit

    • d2c43240 - Issue # 1818764: Added missing argument () in the testUpdateEmail() test method

    Compare with previous version

  • quietone added 5 commits

    added 5 commits

    • 1d8d0b03 - Update message and add tests
    • c32e0dd0 - Rework the logic for the subject line
    • 57fe4048 - Issue #1818764 by xurizaemon, quietone, haydeniv, amitgoyal, smustgrave, xjm,...
    • d8782a3a - Issue # 1818764: Fixed some PHPCS and PHPSTAN issues reported by the pipeline jobs
    • daf7306f - fix rebase

    Compare with previous version

  • Tyler Staples added 1 commit

    added 1 commit

    • d945ccc5 - Issue #1818764: Update subject lines to be 80 characters long to appease the review bot.

    Compare with previous version

  • quietone added 170 commits

    added 170 commits

    • d945ccc5...a2db325e - 164 commits from branch project:11.x
    • 74cea444 - Update message and add tests
    • ce5b582c - Rework the logic for the subject line
    • 52e82b95 - Issue #1818764 by xurizaemon, quietone, haydeniv, amitgoyal, smustgrave, xjm,...
    • ae964b6a - Issue # 1818764: Fixed some PHPCS and PHPSTAN issues reported by the pipeline jobs
    • 00540182 - fix rebase
    • 41d150d6 - Issue #1818764: Update subject lines to be 80 characters long to appease the review bot.

    Compare with previous version

  • quietone added 1 commit
  • Please register or sign in to reply
    Loading