improve update status email subject
2 unresolved threads
2 unresolved threads
Closes #1818764
Merge request reports
Activity
added 126 commits
-
9a719962...82d325ee - 125 commits from branch
project:11.x
- 7998ca80 - Update message and add tests
-
9a719962...82d325ee - 125 commits from branch
- Resolved by quietone
- Resolved by quietone
404 $subject = t('Security release(s) available for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]); 405 } 406 407 // If no subject yet then check for fetch failures. If all the reasons 408 // are fetch failures the use the fetch subject. 409 if (empty($subject)) { 410 $fetch = array_filter($all_reasons, function ($item) { 411 return $item > 0; 412 }); 413 if (empty($fetch) && !empty($all_reasons)) { 414 $subject = t('Failed to get release information for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]); 415 } 416 } 417 418 // If still no subject, then there are non-security updates and use the non- 419 // security subject. Then update the subject in the existing message. - Comment on lines +418 to +419
418 // If still no subject, then there are non-security updates and use the non- 419 // security subject. Then update the subject in the existing message. 418 // If the subject still has not been set, then there are only non-security 419 // updates. Use the subject for non-security updates. changed this line in version 4 of the diff
408 // are fetch failures the use the fetch subject. 409 if (empty($subject)) { 410 $fetch = array_filter($all_reasons, function ($item) { 411 return $item > 0; 412 }); 413 if (empty($fetch) && !empty($all_reasons)) { 414 $subject = t('Failed to get release information for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]); 415 } 416 } 417 418 // If still no subject, then there are non-security updates and use the non- 419 // security subject. Then update the subject in the existing message. 420 if (empty($subject)) { 421 $subject = t('New release(s) available for @site_name', ['@site_name' => \Drupal::config('system.site')->get('name'), 'langcode' => $langcode]); 422 } 423 $message['subject'] .= $subject; changed this line in version 12 of the diff
- Resolved by quietone
added 1 commit
added 1521 commits
-
7c880d4b...93ec7a93 - 1520 commits from branch
project:11.x
- 05379fea - Merge branch '11.x' into '1818764-correct--improve'
-
7c880d4b...93ec7a93 - 1520 commits from branch
added 211 commits
-
05379fea...10a80a91 - 210 commits from branch
project:11.x
- 8d611611 - Issue # 1818764: Fixed conflicts after rebasing at file:...
-
05379fea...10a80a91 - 210 commits from branch
added 1 commit
- f308ee46 - Issue # 1818764: Fixed some PHPCS and PHPSTAN issues reported by the pipeline jobs
added 1 commit
- d2c43240 - Issue # 1818764: Added missing argument () in the testUpdateEmail() test method
added 5 commits
Toggle commit listadded 1 commit
added 170 commits
-
d945ccc5...a2db325e - 164 commits from branch
project:11.x
- 74cea444 - Update message and add tests
- ce5b582c - Rework the logic for the subject line
- 52e82b95 - Issue #1818764 by xurizaemon, quietone, haydeniv, amitgoyal, smustgrave, xjm,...
- ae964b6a - Issue # 1818764: Fixed some PHPCS and PHPSTAN issues reported by the pipeline jobs
- 00540182 - fix rebase
- 41d150d6 - Issue #1818764: Update subject lines to be 80 characters long to appease the review bot.
Toggle commit list-
d945ccc5...a2db325e - 164 commits from branch
Please register or sign in to reply