Initial commit from the patch in #154 comment.
2 unresolved threads
2 unresolved threads
Resolve the merge conflicts. Perform other necessary changes.
Closes #2640994
Merge request reports
Activity
added 283 commits
-
4ed94e88...67f56fc2 - 280 commits from branch
project:11.x
- a6e7692a - Initial commit from the patch in #154 comment.
- df6212c8 - Use attribute for the new plugin.
- 6deecc39 - Phpstan fixes.
Toggle commit list-
4ed94e88...67f56fc2 - 280 commits from branch
added 1 commit
added 8 commits
-
49042a3e...449f6fbf - 2 commits from branch
project:11.x
- 2320b38b - Initial commit from the patch in #154 comment.
- 69225e50 - Use attribute for the new plugin.
- 18307d46 - Phpstan fixes.
- 0c205df0 - [#2640994] Remove stale config from view.test_entity_id_argument.yml
- 7885c916 - [#2778345]: Convert post_update to use ViewsConfigUpdater
- cd776bdf - [#2778345]: Regenerate view.test_entity_id_argument_update.yml fixture with 10.2.x core
Toggle commit list-
49042a3e...449f6fbf - 2 commits from branch
added 1 commit
added 1 commit
added 1 commit
added 22 commits
-
f66d8acd...f45c7bd1 - 11 commits from branch
project:11.x
- 74dc08a6 - 1 earlier commit
- 0cbbab32 - Use attribute for the new plugin.
- 02cc9f78 - Phpstan fixes.
- fd01dda4 - [#2640994] Remove stale config from view.test_entity_id_argument.yml
- 0a76e9f1 - [#2778345]: Convert post_update to use ViewsConfigUpdater
- 76b990f1 - [#2778345]: Regenerate view.test_entity_id_argument_update.yml fixture with 10.2.x core
- 8f5c4b83 - [#2778345]: Remove unused use in views.post_update.php
- 0634ceb4 - [#2778345]: Fix bug in ViewsConfigUpdater where we assumed argument plugins too early
- 981410f2 - [#2778345]: Make ViewsConfigUpdater more resiliant to incomplete config
- 06578b8b - [#2778345]: Update Umami's views.view.related_recipes.yml to use entity_target_id argument plugin
- 5b37d806 - [#2778345]: Remove now-irrelevant ViewsArgumentDeprecationTest
Toggle commit list-
f66d8acd...f45c7bd1 - 11 commits from branch
added 5 commits
- 5f0b7f27 - [#2778345]: Fix some nits in EntityArgumentTest
- e2c892c9 - [#2778345]: Fix some nits in EntityArgumentUpdateTest
- 309b85c2 - [#2778345]: Standardize on 1-line classes to extend EntityArgument:
- 415a32b5 - [#2778345]: Safely handle deprecated constructor params and property access in EntityArgument:
- a92f3460 - [#2778345]: Fix ViewsArgumentDeprecationTest to behave like the old Taxonomy...
Toggle commit listadded 1 commit
added 1 commit
added 1 commit
2 3 declare(strict_types=1); 4 5 namespace Drupal\Tests\views\Functional\Plugin; 6 7 use Drupal\Tests\taxonomy\Functional\Views\TaxonomyTestBase; 8 use Drupal\views\Tests\ViewTestData; 9 use Drupal\views\Views; 10 11 /** 12 * Tests the handler of the view: entity target argument. 13 * 14 * @group views 15 * @see \Drupal\views\Plugin\views\argument\EntityArgument 16 */ 17 class EntityArgumentTest extends TaxonomyTestBase { This is the only test in the
Drupal\Tests\views
namespace thatextends TaxonomyTestBase
.- Is this a good idea?
- Should we rework this to rely on a different entity type so we don't have the external dependency?
- Should we move the test to
taxonomy
?
I think #3 isn't good. I don't really want to spend the time on #2. But I'm not convinced of #1.
Thoughts? Thanks!
added 1 commit
added 29 commits
-
ded55b29...360a9c58 - 4 commits from branch
project:11.x
- 360a9c58...5835a572 - 15 earlier commits
- 748f9e92 - [#2778345]: Fix phpcs, phpstan, and cspell errors in EntityArgument from commit 415a32b5 ;)
- 30db0f02 - [#2778345]: Remove unused used from TaxonomyViewsArgumentTest
- cf25bdeb - [#2778345]: Fix typo in TaxonomyViewsArgumentTest
- 5f7cb3d8 - [#2778345]: Per Slack with @mstrelan phpstan won't know the type of promoted...
- 3f095f0c - [#2778345]: Flip pattern for deprecation dance in EntityArgument to avoid else
- 194c54dc - [#2778345]: Use property promotion in EntityReferenceArgument to add types and simplify
- 16feb3f6 - [#2778345]: Add typehints to EntityArgumentTest
- d08cd7e5 - [#2778345]: Fix new phpstan errors in EntityArgumentTest
- 9c12d214 - [#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument
- 9336ae1d - [#2640994]: Update docs for core_field_views_data() per @Lendude review
Toggle commit list-
ded55b29...360a9c58 - 4 commits from branch
added 1 commit
added 1 commit
added 3 commits
- 4d54d97b - Revert "[#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument"
- 89d22118 - Revert "[#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument"
- c810384a - [#2640994]: Clarify the documentation for EntityArgument vs. EntityReferenceArgument
added 40 commits
-
c810384a...cbad32ab - 7 commits from branch
project:11.x
- cbad32ab...411494fe - 23 earlier commits
- 68af090a - [#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument
- e15b0bb5 - [#2640994]: Update docs for core_field_views_data() per @Lendude review
- 983ba499 - [#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument
- cd44865f - [#2640994]: Remove the 'deprecation dance' from the 11.x MR since the BC layer...
- 35682190 - [#2640994]: Fix phpcs errors from previous commit: unused use and extra newline
- e5dd5104 - [#2640994]: Remove deprecation test from 11.x since the BC layer is gone
- 682a1e02 - Revert "[#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument"
- 59ea094f - Revert "[#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument"
- 21c898bb - [#2640994]: Clarify the documentation for EntityArgument vs. EntityReferenceArgument
- 175b2fef - [#2640994] switch to 10.3.0 fixture for EntityArgumentUpdateTest now that [#3442172] happened
Toggle commit list-
c810384a...cbad32ab - 7 commits from branch
added 66 commits
-
175b2fef...bfaae1b1 - 33 commits from branch
project:11.x
- bfaae1b1...7a76ca48 - 23 earlier commits
- f95e358a - [#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument
- be02b02d - [#2640994]: Update docs for core_field_views_data() per @Lendude review
- f1ef1e08 - [#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument
- 5d7ddca0 - [#2640994]: Remove the 'deprecation dance' from the 11.x MR since the BC layer...
- 108f7ac1 - [#2640994]: Fix phpcs errors from previous commit: unused use and extra newline
- 4517fced - [#2640994]: Remove deprecation test from 11.x since the BC layer is gone
- a50beb99 - Revert "[#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument"
- 4c8d04fb - Revert "[#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument"
- b0b25f5d - [#2640994]: Clarify the documentation for EntityArgument vs. EntityReferenceArgument
- ef37d720 - [#2640994] switch to 10.3.0 fixture for EntityArgumentUpdateTest now that [#3442172] happened
Toggle commit list-
175b2fef...bfaae1b1 - 33 commits from branch
548 551 return $changed; 549 552 } 550 553 554 /** 555 * Checks if 'numeric' arguments should be converted to 'entity_target_id'. 556 * 557 * @param \Drupal\views\ViewEntityInterface $view 558 * The view entity. 559 * 560 * @return bool 561 * TRUE if the view has any arguments that reference an entity reference 562 * that need to be converted from 'numeric' to 'entity_target_id'. 563 */ 564 public function needsEntityArgumentUpdate(ViewEntityInterface $view) { changed this line in version 29 of the diff
added 132 commits
-
b6afd225...14a0a6d2 - 98 commits from branch
project:11.x
- 14a0a6d2...7748bbc4 - 24 earlier commits
- 76ebe56e - [#2640994]: Update docs for core_field_views_data() per @Lendude review
- 4b151dd9 - [#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument
- e90f39a9 - [#2640994]: Remove the 'deprecation dance' from the 11.x MR since the BC layer...
- 5ef25f26 - [#2640994]: Fix phpcs errors from previous commit: unused use and extra newline
- 2195b7ff - [#2640994]: Remove deprecation test from 11.x since the BC layer is gone
- 68374290 - Revert "[#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument"
- a9565bbf - Revert "[#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument"
- 289a1975 - [#2640994]: Clarify the documentation for EntityArgument vs. EntityReferenceArgument
- e1cfe158 - [#2640994] switch to 10.3.0 fixture for EntityArgumentUpdateTest now that [#3442172] happened
- 1c3d046a - Apply 1 suggestion(s) to 1 file(s)
Toggle commit list-
b6afd225...14a0a6d2 - 98 commits from branch
added 129 commits
-
1c3d046a...2e3e8746 - 94 commits from branch
project:11.x
- 2e3e8746...934d14d3 - 25 earlier commits
- 719a59d8 - [#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument
- d013baa0 - [#2640994]: Remove the 'deprecation dance' from the 11.x MR since the BC layer...
- 8168f0eb - [#2640994]: Fix phpcs errors from previous commit: unused use and extra newline
- 9c4ee6b4 - [#2640994]: Remove deprecation test from 11.x since the BC layer is gone
- 5c81c20b - Revert "[#2640994] Remove EntityReferenceArgument and update everything to use EntityArgument"
- 06ecbfb4 - Revert "[#2640994] Fix expectations in EntityViewsDataTest now that we only have EntityArgument"
- ccb98869 - [#2640994]: Clarify the documentation for EntityArgument vs. EntityReferenceArgument
- 12d2a665 - [#2640994] switch to 10.3.0 fixture for EntityArgumentUpdateTest now that [#3442172] happened
- 256af861 - Apply 1 suggestion(s) to 1 file(s)
- 6f37ef52 - [#2640994] task(views): Trigger deprecations in ViewsConfigUpdater::processEntityArgumentUpdate()
Toggle commit list-
1c3d046a...2e3e8746 - 94 commits from branch
added 1 commit
added 1 commit
added 1 commit
Please register or sign in to reply