Draft: Symfony 7 without ContainerAwareInterface
1 unresolved thread
1 unresolved thread
$ vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline core/.phpstan-baseline.php
Closes #3394694
Merge request reports
Activity
added 1 commit
- 237ecd60 - Remove remaining uses of ContainerAwareInterface.
added 1 commit
- 2050344f - doctrine/annotations fork is not compatible with doctrine/lexer 3.
added 2 commits
added 1 commit
- 95a33fe4 - user_validate_name() requires a non-NULL label for the dummy base field for...
added 34 commits
-
95a33fe4...23bb407d - 15 commits from branch
project:11.x - 23bb407d...042be957 - 9 earlier commits
- 48018042 - Remove remaining uses of ContainerAwareInterface.
- a780f825 - doctrine/annotations fork is not compatible with doctrine/lexer 3.
- 6f7671d6 - Fix RequestFactory.
- 48d67895 - MINIMUM_PHP => 8.2.0
- 0968afb5 - Not all Bags are equal
- bc3364ff - Not all Bags are equal
- 3cf94c6f - MINIMUM_PHP => 8.2.0
- ff0c13be - user_validate_name() requires a non-NULL label for the dummy base field for...
- f82a003a - Use user_validate_name() in UserPasswordForm.
- 6745db0b - Add labels to all BaseFieldDefinition objects.
Toggle commit list-
95a33fe4...23bb407d - 15 commits from branch
161 160 $this->flood->register('user.password_request_ip', $flood_config->get('ip_window')); 162 161 // First, see if the input is possibly valid as a username. 163 162 $name = trim($form_state->getValue('name')); 164 $definition = BaseFieldDefinition::create('string') 165 ->addConstraint('UserName', []); 166 $data = $this->typedDataManager->create($definition); 167 $data->setValue($name); 168 $violations = $data->validate(); 169 163 // Usernames have a maximum length shorter than email addresses. Only print 170 164 // this error if the input is not valid as a username or email address. 171 if ($violations->count() > 0 && !$this->emailValidator->isValid($name)) { 165 if (!is_null(user_validate_name($name)) && !$this->emailValidator->isValid($name)) { -
This seems like it could be unrelated. The code in
user_validate_name()looks more-or-less identical to the removed code here. So +1 for DRY, however it seems that this shouldn't then be necessary for Symfony 7 compatibility and could/should be done in a separate issue that deprecates the function version, or refactors this as proposed here?
Please register or sign in to reply