Issue #3427046: Shortcuts toolbar links are not updated automatically when...
Merge request reports
Activity
added 1 commit
added 15 commits
-
ffee3db3...9bfa224a - 13 commits from branch
project:11.x
- c9273456 - Merge remote-tracking branch 'origin/11.x' into 3427046-shortcuts-default-toolbar-links
- d0306e05 - Merge remote-tracking branch 'origin/11.x' into 3427046-shortcuts-default-toolbar-links
-
ffee3db3...9bfa224a - 13 commits from branch
added 1 commit
- Resolved by Pablo López
- Resolved by Pablo López
- Resolved by Pablo López
- Resolved by Pablo López
- Resolved by Pablo López
- Resolved by Pablo López
added 110 commits
-
9b4e2254...28881d63 - 106 commits from branch
project:11.x
- b005f6be - Merge branch '11.x' into 3427046-shortcuts-default-toolbar-links
- ccb949a4 - Issue #3427046: Apply code suggestions
- 6aa4ed97 - Issue #3427046: Document the default shortcut cache tag prefix constant
- 4a2163d9 - Issue #3427046: Add tests for unassign operation
Toggle commit list-
9b4e2254...28881d63 - 106 commits from branch
added 1 commit
added 1 commit
82 83 $this->connection->delete('shortcut_set_users') 83 84 ->condition('set_name', $entity->id()) 84 85 ->execute(); 86 drupal_static_reset('shortcut_current_displayed_set'); 85 87 } 86 88 87 89 /** 88 90 * {@inheritdoc} 89 91 */ 90 92 public function assignUser(ShortcutSetInterface $shortcut_set, $account) { 93 $current_shortcut_set = shortcut_current_displayed_set($account); Yeah I tried using \Drupal\shortcut\ShortcutSetStorage::getAssignedToUser() but it didn't work. I think this issue should give us the motivation to move shortcut_current_displayed_set() to ShortcutSetStorage... we will have fun with the drupal_static but we've done a deprecation in drupal_static() function before. Also we should deprecate shortcut_default_set() in favour of the already existing \Drupal\shortcut\ShortcutSetStorage::getDefaultSet()
Love how simple things can escalate quickly when you start to dig into that...
Do you have any example of
drupal_static()
deprecation at hand to take a look into it?Thank you!
Edited by Pablo Lópezchanged this line in version 9 of the diff
added 18 commits
-
a62bccbc...467483fe - 16 commits from branch
project:11.x
- 3c5077a7 - Merge remote-tracking branch 'origin/11.x' into 3427046-shortcuts-default-toolbar-links
- d3c051a0 - Issue #3427046: Move logic to second step to avoid unnecessary API calls
-
a62bccbc...467483fe - 16 commits from branch
- Resolved by Pablo López