Skip to content
Snippets Groups Projects

Issue #3427046: Shortcuts toolbar links are not updated automatically when...

Issue #3427046: Shortcuts toolbar links are not updated automatically when default shortcut set is changed

Closes #3427046

Merge request reports

Code Quality is loading
Test summary results are being parsed

Closed by quietonequietone 1 year ago (Apr 2, 2024 7:13am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pablo López added 110 commits

    added 110 commits

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Pablo López resolved all threads

    resolved all threads

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • 82 83 $this->connection->delete('shortcut_set_users')
    83 84 ->condition('set_name', $entity->id())
    84 85 ->execute();
    86 drupal_static_reset('shortcut_current_displayed_set');
    85 87 }
    86 88
    87 89 /**
    88 90 * {@inheritdoc}
    89 91 */
    90 92 public function assignUser(ShortcutSetInterface $shortcut_set, $account) {
    93 $current_shortcut_set = shortcut_current_displayed_set($account);
    • Yeah I tried using \Drupal\shortcut\ShortcutSetStorage::getAssignedToUser() but it didn't work. I think this issue should give us the motivation to move shortcut_current_displayed_set() to ShortcutSetStorage... we will have fun with the drupal_static but we've done a deprecation in drupal_static() function before. Also we should deprecate shortcut_default_set() in favour of the already existing \Drupal\shortcut\ShortcutSetStorage::getDefaultSet()

    • Love how simple things can escalate quickly when you start to dig into that... :smile:

      Do you have any example of drupal_static() deprecation at hand to take a look into it?

      Thank you!

      Edited by Pablo López
    • Pablo López changed this line in version 9 of the diff

      changed this line in version 9 of the diff

    • Please register or sign in to reply
  • Pablo López added 2 commits

    added 2 commits

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Pablo López added 18 commits

    added 18 commits

    • a62bccbc...467483fe - 16 commits from branch project:11.x
    • 3c5077a7 - Merge remote-tracking branch 'origin/11.x' into 3427046-shortcuts-default-toolbar-links
    • d3c051a0 - Issue #3427046: Move logic to second step to avoid unnecessary API calls

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading