#3426506 Create enums for File exists behaviours and deprecate consts

Closes #3426506

added 1 commit

• f8cb13b3 - Fix migration config

Compare with previous version

added 1 commit

• 58e84c36 - Use enum value for error

Compare with previous version

added 1 commit

• 72b0b547 - Fix test fails

Compare with previous version

added 18 commits

• 72b0b547...b4a9a825 - 14 commits from branch project:11.x
• 15a4331e - #3426506 Create enums for File exists behaviours and deprecate consts
• dfe00f87 - Fix migration config
• 254eb528 - Use enum value for error
• bda0a45c - Fix test fails

Compare with previous version

added 1 commit

• 899dd54f - Switch to PascalCase

Compare with previous version

Wondering if this really needs to be backed by an int. The only place the int value is used is in the options list used in test modules. We could probably match what's currently in progress on https://www.drupal.org/project/drupal/issues/3424769 where we dropped the int backing.

added 16 commits

• 899dd54f...6e7fa7f3 - 10 commits from branch project:11.x
• c27cc16d - #3426506 Create enums for File exists behaviours and deprecate consts
• 39d6fbb3 - Fix migration config
• 1ae7fd08 - Use enum value for error
• dc53b3b0 - Fix test fails
• 184a7ac6 - Switch to PascalCase
• 537b43f8 - Feedback

Compare with previous version

I think it should be backed by an int. We save these values to config. There would be a lot more changes needed to support that BC layer. I don't think it's worth it.

resolved all threads

added 1 commit

• 09497b12 - Don't use int backed enum

Compare with previous version

added 1 commit

• c09c46c1 - Fix deprecation message

Compare with previous version

This looks great, only one question if we can actually change the param types here or if we need to keep them untyped for BC and add them later?

added 19 commits

• c09c46c1...d641102d - 11 commits from branch project:11.x
• db91da23 - #3426506 Create enums for File exists behaviours and deprecate consts
• d024ffd8 - Fix migration config
• 2baea87d - Use enum value for error
• 6169ccbb - Fix test fails
• 3fbd84e5 - Switch to PascalCase
• 3fdcd7db - Feedback
• e6c6874a - Don't use int backed enum
• fc86d67c - Fix deprecation message

Compare with previous version

added 1 commit

• 4466fc77 - Comment out type hints

Compare with previous version

added 75 commits

• 4466fc77...f0dfe7d4 - 66 commits from branch project:11.x
• 303b8a80 - #3426506 Create enums for File exists behaviours and deprecate consts
• ae95d86d - Fix migration config
• e8302eba - Use enum value for error
• ec6af9ae - Fix test fails
• 38105b1f - Switch to PascalCase
• 633df299 - Feedback
• 5c3660f9 - Don't use int backed enum
• 40884f76 - Fix deprecation message
• 4dae1387 - Comment out type hints

Compare with previous version

added 1 commit

• 5997fadd - Change deprecation to drupal 12

Compare with previous version

added 110 commits

• 5997fadd...16964d02 - 100 commits from branch project:11.x
• 269f07c7 - #3426506 Create enums for File exists behaviours and deprecate consts
• 7ba0e1af - Fix migration config
• 56fb062e - Use enum value for error
• a8eeddcc - Fix test fails
• 00e6e364 - Switch to PascalCase
• 0cc2fee0 - Feedback
• ab67e754 - Don't use int backed enum
• 329f3999 - Fix deprecation message
• f0f2d877 - Comment out type hints
• 37b2d072 - Change deprecation to drupal 12

Compare with previous version

resolved all threads

added 1 commit

• 8845c5e4 - Default to FileExists::Replace

Compare with previous version

added 1 commit

• a31b9f44 - Change legacy test

Compare with previous version

added 71 commits

• a31b9f44...efe11919 - 59 commits from branch project:11.x
• efe11919...b701395d - 2 earlier commits
• 17e8760a - Use enum value for error
• ac60c0f9 - Fix test fails
• 43c60828 - Switch to PascalCase
• 919257df - Feedback
• 9ad06447 - Don't use int backed enum
• 07e74f8e - Fix deprecation message
• fe286a1d - Comment out type hints
• e2835e60 - Change deprecation to drupal 12
• f469240d - Default to FileExists::Replace
• 52aea18a - Change legacy test

Compare with previous version

closed