Resolve #3353778 "Argument type"
4 unresolved threads
4 unresolved threads
Closes #3353778
Merge request reports
Activity
added 1933 commits
-
a0ee865c...5dc03f8a - 1927 commits from branch
project:11.x - 793677fa - Update file UpdateSettingsForm.php
- 997d07c1 - Update file UpdateSettingsForm.php
- 1cd291c5 - Update file UpdateSettingsForm.php
- 786a8e74 - Update UpdateSettingsForm.php
- 862614fa - UpdateSettingsForm keeps failing with an isset() check
- 7a910b53 - Add a regression test
Toggle commit list-
a0ee865c...5dc03f8a - 1927 commits from branch
added 1 commit
- 3e6bc9e8 - Keep a possibly existing notification email stored as a string
1 <?php 2 3 declare(strict_types=1); 4 5 namespace Drupal\Tests\update\Functional; 6 7 use Drupal\Core\Url; 8 use Drupal\Tests\BrowserTestBase; 9 10 /** 11 * Update module regression tests. 12 * 13 * @group update 14 * 15 * @internal 32 protected function setUp(): void { 33 parent::setUp(); 34 35 // Create an admin user. 36 $admin_user = $this->drupalCreateUser([ 37 'administer site configuration', 38 'access administration pages', 39 ]); 40 $this->drupalLogin($admin_user); 41 42 } 43 44 /** 45 * Ensure `notification.emails` config set as a string doesn't throw an error. 46 * 47 * @see https://www.drupal.org/project/drupal/issues/3353778 
The same here. I just followed the naming approach in regression tests, like
JsonApiRegressionTest,BigPipeRegressionTestorRegressionTest. The issue link is present at least inJsonApiRegressionTestandBigPipeRegressionTest, and the issue number in the method name is present in all of them. It seemed strange to me at first, but I thought it was already discussed and agreed on.
34 35 // Create an admin user. 36 $admin_user = $this->drupalCreateUser([ 37 'administer site configuration', 38 'access administration pages', 39 ]); 40 $this->drupalLogin($admin_user); 41 42 } 43 44 /** 45 * Ensure `notification.emails` config set as a string doesn't throw an error. 46 * 47 * @see https://www.drupal.org/project/drupal/issues/3353778 48 */ 49 public function testNotificationEmailsAsStringDoesNotThrowAnErrorFromIssue3353778(): void { -
@smustgrave I've replied to your comments.
Please register or sign in to reply