Skip to content
Snippets Groups Projects

Resolve #3422904 "System config"

Resolve #3422904 "System config"
issue/drupal-3422904:3422904-system-config into 11.x
3 open threads
Open
Wim Leersrequested to merge
issue/drupal-3422904:3422904-system-config into 11.x
3 open threads

Closes #3422904

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/system/config/schema/system.schema.yml
3 3 system.site:
4 4 type: config_object
5 5 label: 'Site information'
6 constraints:
7 FullyValidatable: ~
6 8 mapping:
7 9 uuid:
8 10 type: uuid
9 11 label: 'Site UUID'
10 constraints:
11 Uuid: []
12 NotNull: []
  • Comment on lines 7 to -12
    Wim Leers
    Wim Leers @wimleers
    Author Developer

    Dear committer,

    These changes are not strictly necessary. But they do bring more clarity, because:

    • type: uuid already has the Uuid validation constraint, and is inherited here
    • NotNull is already applied automatically by \Drupal\Core\Config\TypedConfigManager::buildDataDefinition() because this config object is marked as fully validatable (thanks to #3364109)
  • Please register or sign in to reply
  • Wim Leers
    Wim Leers @wimleers started a thread on the diff
    • core/modules/system/config/schema/system.schema.yml
    141 constraints:
    142 FullyValidatable: ~
    129 143 mapping:
    130 144 error_level:
    131 145 type: string
    132 146 label: 'Error messages to display'
    147 constraints:
    148 Choice:
    149 # @see ERROR_REPORTING_HIDEs
    150 - hide
    151 # @see ERROR_REPORTING_DISPLAY_SOME
    152 - some
    153 # @see ERROR_REPORTING_DISPLAY_ALL
    154 - all
    155 # @see ERROR_REPORTING_DISPLAY_VERBOSE
    156 - verbose
  • Wim Leers added 1 commit

    added 1 commit

    • 57dc7879 - `langcode` key was missing from `system.logging`.

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • ec3c81bb - Update `system.logging` migration expectations — this matches many similar...

    Compare with previous version

  • Wim Leers added 2 commits

    added 2 commits

    • 8202dd99 - Fix `ExtensionExistsConstraintValidator` to support optional values.
    • 3de1c8f6 - Make `system.theme` fully validatable.

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H
    Adam G-H @phenaproxima started a thread on the diff
    • core/modules/system/config/schema/system.schema.yml
    38 37 weight_select_max:
    39 38 type: integer
    40 39 label: 'Weight element maximum value'
    40 constraints:
    41 Range:
    42 # @see PHP_INT_MAX
    43 max: 2147483647
    • Comment on lines +42 to +43
      Adam G-H
      Adam G-H @phenaproxima
      Developer

      Isn't this only the max integer on 32 bit systems? Pretty sure 64 bit systems (i.e., everything) has a much higher maximum int?

      That said, who cares - this is not a limit anyone's likely to hit.

    • Please register or sign in to reply
  • Wim Leers added 1 commit

    added 1 commit

    • f2dc3b32 - Mark `system.theme:admin` as an optional key.

    Compare with previous version

  • Adam G-H added 181 commits

    added 181 commits

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 88ff4b22 - The chicken vs egg problem also applies to `system.theme` overrides in install profiles.

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • f6cbad00 - Two more chicken vs egg situations, and two actual bugs.

    Compare with previous version

    • Please register or sign in to reply