Convert the patch to an MR.
1 unresolved thread
1 unresolved thread
Closes #3379885
Merge request reports
Activity
Filter activity
added 2 commits
added 1 commit
- 06b32a1a - Inject the message service and implement constructor bc.
- Resolved by catch
82 82 $this->assertTrue($this->container->get('module_installer')->install(['render_placeholder_message_test'], TRUE), 'Installed modules.'); 83 83 84 84 $this->drupalLogin($this->drupalCreateUser()); 85 $messages_markup = '<div role="contentinfo" aria-label="Status message"'; 86 85 $messages_markup = '<div class="messages messages--status" role="status"'; That's because this message is rendered via AjaxCommand instead of directly within the placeholder - i.e. it's produced by a placeholder that's replaced after the messages one now, so uses the new mechanism.
The Functional test (BigPipeTest::testBigPipe()) still has coverage for the placeholder/non-ajax rendering though (this was my circular trip in adjusting the test coverage eventually back to how it was).
Ahhhh right, AJAX command-rendered messages have slightly different markup
Edited by Wim Leers
Please register or sign in to reply