Skip to content
Snippets Groups Projects

Convert the patch to an MR.

Open catch requested to merge issue/drupal-3379885:3379885-use-messagescommand- into 11.x
1 unresolved thread

Closes #3379885

Merge request reports

Members who can merge are allowed to add commits.

Merged results pipeline passed for 0b076809

Code Quality is loading
Test summary results are being parsed
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 82 82 $this->assertTrue($this->container->get('module_installer')->install(['render_placeholder_message_test'], TRUE), 'Installed modules.');
    83 83
    84 84 $this->drupalLogin($this->drupalCreateUser());
    85 $messages_markup = '<div role="contentinfo" aria-label="Status message"';
    86
    85 $messages_markup = '<div class="messages messages--status" role="status"';
    • Comment on lines -85 to +85

      :thinking: Why was this change necessary?

    • Author Maintainer

      That's because this message is rendered via AjaxCommand instead of directly within the placeholder - i.e. it's produced by a placeholder that's replaced after the messages one now, so uses the new mechanism.

      The Functional test (BigPipeTest::testBigPipe()) still has coverage for the placeholder/non-ajax rendering though (this was my circular trip in adjusting the test coverage eventually back to how it was).

    • Ahhhh right, AJAX command-rendered messages have slightly different markup :thumbsup:

      :white_check_mark:

      Edited by Wim Leers
    • Please register or sign in to reply
  • catch added 1 commit

    added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading