Skip to content
Snippets Groups Projects

Added overridden Keyword

Closed sumit kumar requested to merge issue/drupal-3420709:3420709-make-it-more into 11.x
1 unresolved thread

Closes #3420709

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gorka G. added 13 commits

    added 13 commits

    Compare with previous version

  • Gorka G. added 1 commit

    added 1 commit

    • 00f48c7f - Updated Test: replaced * and x with emojis

    Compare with previous version

  • Gorka G. added 1 commit

    added 1 commit

    • f5665693 - Second test updated with emojis instead of X and *

    Compare with previous version

  • ressa added 1 commit

    added 1 commit

    • 82918903 - Show CUSTOM THEME string only for themes in custom folder

    Compare with previous version

  • ressa added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Rowlands resolved all threads

    resolved all threads

  • 101 101 $output['debug_info'] .= "\n-->";
    102 102 }
    103 103 }
    104 $output['debug_info'] .= "\n<!-- BEGIN OUTPUT from '" . Html::escape($template_file) . "' -->\n";
    104 // Check if the template_file belongs to a custom theme
    105 $template_override_status_output = "BEGIN OUTPUT";
    106 if (str_contains($template_file, 'custom')) {
    • I know this has been discussed already - but for me there's just too many false positives and false negatives... a module with custom in the name. A contrib theme with custom in the name. The user not using themes/custom/ etc.... for this to be the correct solution.

      If this is actually useful I think it could be changed to detect whether the template is from the active theme.

    • Gorka G. changed this line in version 10 of the diff

      changed this line in version 10 of the diff

    • Hi @alexpott I did a new commit with your suggestion as i think $variables['directory'] contains the active theme so we can use it

    • Please register or sign in to reply
  • Gorka G. added 1 commit

    added 1 commit

    • 5127f949 - New approach for overriding only when the template is deprecated

    Compare with previous version

  • Gorka G. added 1 commit

    added 1 commit

    Compare with previous version

  • Gorka G. added 1 commit

    added 1 commit

    • 6c2207b8 - Update end text in debug and fixed test

    Compare with previous version

  • Please register or sign in to reply
    Loading