Skip to content
Snippets Groups Projects

Sorting nodes by title aren't returned in correct order.

3 unresolved threads

This PR includes latest changes from https://www.drupal.org/project/drupal/issues/3186834#comment-15425338 onwards

Additionally, fixed following things:

  • Fixing test case failures.
  • Fix the deprecation message formatting.
  • Add the necessary trait for expectDeprecation methods.
  • Add additional test case to validate the sort order when sort happens on non translatable field. This case was raised in comment #54

Closes #3186834

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline failed for a620cca6

Code Quality is loading
Test summary results are being parsed
Ready to merge by members who can write to the target branch.

Merge details

  • The source branch is 2173 commits behind the target branch.
  • 1 commit will be added to 11.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
189 202 $this->serializer = $serializer;
190 203 $this->time = $time;
191 204 $this->user = $user;
205 if ($language_manager === NULL) {
206 @trigger_error(__NAMESPACE__ . '\EntityResource::__construct() without the language_manager service is deprecated in drupal:10.2.3 The language_manager dependency was added in drupal:10.2.3 and will be required before drupal:11.0.0. See https://www.drupal.org/node/3357049', E_USER_DEPRECATED);
  • 151 155 */
    152 156 protected $user;
    153 157
    158 /**
    159 * The language manager.
    160 *
    161 * @var \Drupal\Core\Language\LanguageManagerInterface
    162 */
    163 protected $languageManager;
  • 238 250 $this->assertEquals(['node_list'], $response->getCacheableMetadata()->getCacheTags());
    239 251 }
    240 252
    253 /**
    254 * Test the language_manager argument deprecation.
    255 *
    256 * @group legacy
    257 */
    258 public function testEntityResourceNewParameterDeprecation(): void {
    259 $this->expectDeprecation(EntityResource::class . '::__construct() without the language_manager service is deprecated in drupal:10.2.3 The language_manager dependency was added in drupal:10.2.3 and will be required before drupal:11.0.0. See https://www.drupal.org/node/3357049');
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading