Skip to content
Snippets Groups Projects

Issue #3212891: Incorrect type declaration in docblock for class property

Open Issue #3212891: Incorrect type declaration in docblock for class property
issue/drupal-3212891:3212891-incorrect-type-declaration into 9.3.x
1 unresolved thread
Open Vojislav Jovanovic requested to merge issue/drupal-3212891:3212891-incorrect-type-declaration into 9.3.x
1 unresolved thread

Merge request reports

Members who can merge are allowed to add commits.
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/migrate/src/Plugin/migrate/id_map/Sql.php
111 111 /**
112 112 * The result.
113 113 *
114 * @var null
114 * @var \Drupal\Core\Database\StatementInterface|null
115 115 */
116 116 protected $result = NULL;
  • Comment on lines -114 to 116
    A
    Alex Pott @alexpott
    Maintainer

    I think we should remove the assignment to NULL - it's pointless - see https://3v4l.org/01XIi

    And also I think we should remove the |null - all class properties are that implicitly and once this is set to a StatementInterface object it'll never not be set.

    Also I think we should fix

      /**
   * The current row.
   *
   * @var null
   */
  protected $currentRow = NULL;

    at the same time. This is array|false|null - we should note this null because we do explicitly set it to NULL in rewind().

  • Brent Gees changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Please register or sign in to reply
  • Brent Gees added 1 commit

    added 1 commit

    Compare with previous version

  • Srilakshmi R added 1 commit

    added 1 commit

    • c2e9ee6a - Removed |null from docblock for @result

    Compare with previous version

    • Please register or sign in to reply