Issue #3392621: Use POST requests for fetching of ckeditor embedded media previews
1 unresolved thread
Closes #3392621
Merge request reports
Activity
added 1 commit
added 1 commit
added 1 commit
added 1 commit
126 126 // want to verify that Media preview responses are cached on the client side 127 127 // so it is essential that rerendering occurs. To achieve this, we append a 128 128 // single space. 129 $source_text_area = $this->getSession()->getPage()->find('css', '[name="body[0][value]"] + .ck-editor textarea'); 130 $source_text_area->setValue($source_text_area->getValue() . ' '); 131 $this->pressEditorButton('Source'); 132 $this->assertNotEmpty($assert_session->waitForElementVisible('css', 'img[src*="image-test.png"]')); 133 $this->assertSame(0, $this->getLastPreviewRequestTransferSize()); 129 // @todo re-enable this once https://www.drupal.org/project/drupal/issues/3395776 How would #3395776 help restore this?
That only is referring to Drupal's render cache, not to the browser cache. Browsers never reuse responses to POST requests to my knowledge?
added 491 commits
-
18efab4c...434e19e0 - 485 commits from branch
project:11.x
- e993fb6b - Issue #3392621: Use POST requests for fetching of ckeditor embedded media previews
- a7cbec1f - Issue #3392621: Additional media preview test that checks previews are working...
- 416d0c1b - Issue #3392621: Fixed JS lint errors
- a93fddad - Issue #3392621: Commented out test that verifies caching of preview fetch...
- cb97683e - Issue #3392621: Fixed broken MediaTest after converting to POST request
- 20f8851c - Issue #3392621: Use longer text in value of 'alt' attribute of <drupal-media> element in test
Toggle commit list-
18efab4c...434e19e0 - 485 commits from branch
Please register or sign in to reply