Skip to content
Snippets Groups Projects

Remove withConsecutive() in KeyValueEntityStorageTest.

Remove withConsecutive() in KeyValueEntityStorageTest.
issue/drupal-3417559:3417559-remove-withconsecutive-in into 11.x
1 open thread
Closed
Dave Longrequested to merge
issue/drupal-3417559:3417559-remove-withconsecutive-in into 11.x
1 open thread

Closes #3417559

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/tests/Drupal/Tests/Core/Entity/KeyValueStore/KeyValueEntityStorageTest.php
574 582 $entities['bar'] = $this->getMockEntity(EntityBaseTest::class, [['id' => 'bar']]);
575 583 $this->setUpKeyValueEntityStorage();
576 584
577 $this->moduleHandler->expects($this->exactly(8))
585 $hooks = [
586 'test_entity_type_predelete',
587 'entity_predelete',
588 'test_entity_type_predelete',
589 'entity_predelete',
590 'test_entity_type_delete',
591 'entity_delete',
592 'test_entity_type_delete',
593 'entity_delete',
  • Comment on lines +590 to +593
    Dave Long
    Dave Long @longwave
    Author Maintainer

    This is a bug in the original test, it did not confirm that the delete hooks were called, only predelete. Using the callback means we have to explicitly list each argument.

  • spokje
    spokje @Spokje

    Interesting and scary, didn't know withConsecutive was that "lenient"...

    Anyway, manually verified this and (per usual) @longwave is correct.

  • Please register or sign in to reply
  • Dave Long closed

    closed

    • Please register or sign in to reply