Skip to content
Snippets Groups Projects

Start deleting ckeditor4

Closed quietone requested to merge issue/drupal-3239012:3239012-late-2023-deprecate into 11.x

Closes #3239012

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1561 ['label' => 'ruby', 'language' => 'ruby'],
1562 ['label' => 'sql', 'language' => 'sql'],
1563 ['label' => 'vbscript', 'language' => 'vbscript'],
1564 ['label' => 'xhtml', 'language' => 'xhtml'],
1565 ['label' => 'xml', 'language' => 'xml'],
1566 ],
1567 ],
1568 ],
1569 ],
1570 'expected_superset' => '',
1571 'expected_fundamental_compatibility_violations' => [],
1572 'expected_db_logs' => [],
1573 'expected_messages' => [],
1574 ];
1575
1576 1440 yield "minimal_ckeditor_wrong_allowed_html does not have sufficient allowed HTML => necessary allowed HTML added (1 upgrade message)" => [
  • quietone added 10 commits

    added 10 commits

    Compare with previous version

  • Wim Leers added 242 commits

    added 242 commits

    • 35ff3932...a633060b - 240 commits from branch project:11.x
    • 85f0d408 - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate
    • a5ff8f53 - Remove all references to and uses of `CKEditor5StylesheetsMessage`.

    Compare with previous version

  • Wim Leers
    Wim Leers @wimleers started a thread on the diff
  • 9 use Drupal\Component\Assertion\Inspector;
    10 use Drupal\Core\Cache\CacheBackendInterface;
    11 use Drupal\Core\Extension\ModuleHandlerInterface;
    12 use Drupal\Core\Plugin\DefaultPluginManager;
    13 use Drupal\filter\FilterFormatInterface;
    14
    15 /**
    16 * Provides a CKEditor 4 to 5 upgrade plugin manager.
    17 *
    18 * @see \Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface
    19 * @see \Drupal\ckeditor5\Annotation\CKEditor4To5Upgrade
    20 * @see plugin_api
    21 *
    22 * @internal
    23 */
    24 class CKEditor4To5UpgradePluginManager extends DefaultPluginManager {
  • Wim Leers
    Wim Leers @wimleers started a thread on the diff
  • 212
    213 default:
    214 throw new \OutOfBoundsException();
    215 }
    216 }
    217
    218 /**
    219 * {@inheritdoc}
    220 */
    221 public function computeCKEditor5PluginSubsetConfiguration(string $cke5_plugin_id, FilterFormatInterface $text_format): ?array {
    222 switch ($cke5_plugin_id) {
    223 case 'ckeditor5_heading':
    224 $restrictions = $text_format->getHtmlRestrictions();
    225 if ($restrictions === FALSE) {
    226 // The default is to allow all headings, which makes sense when there
    227 // are no restrictions.
    • Comment on lines -218 to -227

      :thinking: While this seems not specific to CKEditor 4, it does work in tandem with the mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem() method above: that's what ensures that these plugins are enabled, so that this logic can configure them.

      That's why the call to this method should still be removed from \Drupal\ckeditor5\SmartDefaultSettings.

    • Please register or sign in to reply
  • Wim Leers added 1 commit

    added 1 commit

    • 99a68003 - Remove all references to and uses of `CKEditor4To5UpgradePluginManager`.

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 2c47ba7d - When switching to CKE5, all enabled plugins now always use the default...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 0ef38cab - Ensure that when switching from some arbitrary previous text editor, that the...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • d32e4409 - Made the first test case in `SmartDefaultSettingsTest` pass! But this led me...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 65789053 - Improve what happened two commits ago, in...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 8710b48f - Make `\Drupal\ckeditor5\SmartDefaultSettings::getCandidates()` slightly...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • e26e9afd - Update all other `SmartDefaultSettingsTest` test cases to the new reality...

    Compare with previous version

  • Wim Leers added 2 commits

    added 2 commits

    • 0f075643 - @quietone removed some test coverage worth keeping, and didn't delete the...
    • 0f885014 - Tweak the `SmartDefaultSettings` unit test slightly.

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 85b87d0a - Always with the default CKEditor 5 settings.

    Compare with previous version

  • Wim Leers added 2 commits

    added 2 commits

    • fdf8d986 - Just like adding toolbar items based on HTML restrictions starts a new toolbar...
    • 889042f3 - Update test expectations thanks to the last 2 commits. One @todo is now gone! 🥳

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 00ca6d7a - And the last `@todo` bites the dust!

    Compare with previous version

  • Wim Leers added 109 commits

    added 109 commits

    • 00ca6d7a...0697c814 - 108 commits from branch project:11.x
    • a264759c - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate

    Compare with previous version

  • Wim Leers added 121 commits

    added 121 commits

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 0831f2f8 - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading