Start deleting ckeditor4
Closes #3239012
Merge request reports
Activity
1561 ['label' => 'ruby', 'language' => 'ruby'], 1562 ['label' => 'sql', 'language' => 'sql'], 1563 ['label' => 'vbscript', 'language' => 'vbscript'], 1564 ['label' => 'xhtml', 'language' => 'xhtml'], 1565 ['label' => 'xml', 'language' => 'xml'], 1566 ], 1567 ], 1568 ], 1569 ], 1570 'expected_superset' => '', 1571 'expected_fundamental_compatibility_violations' => [], 1572 'expected_db_logs' => [], 1573 'expected_messages' => [], 1574 ]; 1575 1576 1440 yield "minimal_ckeditor_wrong_allowed_html does not have sufficient allowed HTML => necessary allowed HTML added (1 upgrade message)" => [ changed this line in version 2 of the diff
added 10 commits
-
1e69cfb8...19f0ef5c - 8 commits from branch
project:11.x
- 2d00c352 - Start deleting ckeditor4
- 35ff3932 - Remove minimal_ckeditor_wrong_allowed_html from provider
-
1e69cfb8...19f0ef5c - 8 commits from branch
added 242 commits
-
35ff3932...a633060b - 240 commits from branch
project:11.x
- 85f0d408 - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate
- a5ff8f53 - Remove all references to and uses of `CKEditor5StylesheetsMessage`.
-
35ff3932...a633060b - 240 commits from branch
9 use Drupal\Component\Assertion\Inspector; 10 use Drupal\Core\Cache\CacheBackendInterface; 11 use Drupal\Core\Extension\ModuleHandlerInterface; 12 use Drupal\Core\Plugin\DefaultPluginManager; 13 use Drupal\filter\FilterFormatInterface; 14 15 /** 16 * Provides a CKEditor 4 to 5 upgrade plugin manager. 17 * 18 * @see \Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface 19 * @see \Drupal\ckeditor5\Annotation\CKEditor4To5Upgrade 20 * @see plugin_api 21 * 22 * @internal 23 */ 24 class CKEditor4To5UpgradePluginManager extends DefaultPluginManager { 212 213 default: 214 throw new \OutOfBoundsException(); 215 } 216 } 217 218 /** 219 * {@inheritdoc} 220 */ 221 public function computeCKEditor5PluginSubsetConfiguration(string $cke5_plugin_id, FilterFormatInterface $text_format): ?array { 222 switch ($cke5_plugin_id) { 223 case 'ckeditor5_heading': 224 $restrictions = $text_format->getHtmlRestrictions(); 225 if ($restrictions === FALSE) { 226 // The default is to allow all headings, which makes sense when there 227 // are no restrictions. - Comment on lines -218 to -227
While this seems not specific to CKEditor 4, it does work in tandem with themapCKEditor4ToolbarButtonToCKEditor5ToolbarItem()
method above: that's what ensures that these plugins are enabled, so that this logic can configure them.That's why the call to this method should still be removed from
\Drupal\ckeditor5\SmartDefaultSettings
.
added 1 commit
- 99a68003 - Remove all references to and uses of `CKEditor4To5UpgradePluginManager`.
added 1 commit
- 2c47ba7d - When switching to CKE5, all enabled plugins now always use the default...
added 1 commit
- 0ef38cab - Ensure that when switching from some arbitrary previous text editor, that the...
added 1 commit
- d32e4409 - Made the first test case in `SmartDefaultSettingsTest` pass! But this led me...
added 1 commit
- 65789053 - Improve what happened two commits ago, in...
added 1 commit
- 8710b48f - Make `\Drupal\ckeditor5\SmartDefaultSettings::getCandidates()` slightly...
added 1 commit
- e26e9afd - Update all other `SmartDefaultSettingsTest` test cases to the new reality...
added 1 commit
- 85b87d0a - Always with the default CKEditor 5 settings.
added 109 commits
-
00ca6d7a...0697c814 - 108 commits from branch
project:11.x
- a264759c - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate
-
00ca6d7a...0697c814 - 108 commits from branch
added 121 commits
-
a264759c...e7159707 - 119 commits from branch
project:11.x
- 915a32c3 - wip
- 11a2e311 - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate
-
a264759c...e7159707 - 119 commits from branch
added 1 commit
- 0831f2f8 - Merge remote-tracking branch 'origin/11.x' into 3239012-late-2023-deprecate
Please register or sign in to reply