Skip to content
Snippets Groups Projects

converting to MR

Open converting to MR
issue/drupal-3111630:3111630-media-library-upload into 11.x
2 unresolved threads
Open Hardik Patel requested to merge issue/drupal-3111630:3111630-media-library-upload into 11.x
2 unresolved threads

Closes #3111630

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/media_library/src/Form/FileUploadForm.php
161 161 $process = (array) $this->elementInfo->getInfoProperty('managed_file', '#process', []);
162 162 $form['container']['upload'] = [
163 163 '#type' => 'managed_file',
164 '#title' => $this->formatPlural($slots, 'Add file', 'Add files'),
164 '#title' => $this->getSourceFieldLabel($media_type),
  • Hardik Patel added 1 commit

    added 1 commit

    Compare with previous version

  • Hardik Patel added 1 commit

    added 1 commit

    • 8e8a7214 - solving failed test cases in WidgetUploadTest

    Compare with previous version

  • Hardik Patel
    Hardik Patel @Hardik_Patel_12 started a thread on the diff
    • core/modules/media_library/src/Form/FileUploadForm.php
    175 175
    176 176 $file_upload_help = [
    177 177 '#theme' => 'file_upload_help',
    178 '#description' => $this->getSourceFieldDescription($media_type),
    • Hardik Patel
      Hardik Patel @Hardik_Patel_12 ·
      Author

      The description is currently obtained as null through $this->getSourceFieldDescription($media_type). Similar to the above label case, can we directly utilize '#title' => $media_type->getDescription() here? This way, we could eliminate the need for the getSourceFieldDescription() method.

    • Adam Bramley
      Adam Bramley @acbramley ·
      Developer

      We want the description of the source field, not the media type so this is correct.

    • Please register or sign in to reply
  • Adam Bramley added 643 commits

    added 643 commits

    Compare with previous version

    • Please register or sign in to reply