2815881 applying patch #172 against 11.x.
3 unresolved threads
3 unresolved threads
Closes #2815881
Merge request reports
Activity
added 136 commits
-
14c720bf...74fac8eb - 135 commits from branch
project:11.x
- c38ea857 - Merge branch '11.x' of https://git.drupalcode.org/project/drupal into...
-
14c720bf...74fac8eb - 135 commits from branch
added 726 commits
-
c38ea857...67f56fc2 - 725 commits from branch
project:11.x
- 7c963cbe - Merge branch '11.x' into 2815881-switching-on-aggregation-11.x
-
c38ea857...67f56fc2 - 725 commits from branch
added 1 commit
- 8631a74b - Issue 2815881: Add entity type bundle info mock to the invocation, so that it...
added 1 commit
- ee2e66cd - Issue 2815881: Add a label to the image style as it is required by the schema.
added 1 commit
- 4da1518b - Issue 2815881: Pass mocked services to avoid fatal exception in tests.
added 1 commit
- c5c902b6 - Issue 2815881: Check for emptiness of the group_fields property rather than...
added 1 commit
- 62ba9df0 - Issue 2815881: Test for emptiness directly as the testing framework's...
263 263 unset($fields[$entity_type_key]); 264 264 } 265 265 266 if ($use_groupby) { 266 if ($use_groupby && !empty($this->options['group_column'])) { 298 298 */ 299 299 public function add_field_table($use_groupby) { 300 300 // Grouping is enabled. 301 if ($use_groupby) { 301 if ($use_groupby && !empty($this->options['group_column'])) { - Comment on lines -301 to +301
611 * 612 * Some fields could be saved without a group column, this assures that every 613 * field has a default group column. 614 * 615 * @param array $handler 616 * A display handler. 617 * @param string $handler_type 618 * The handler type. 619 * @param string $key 620 * The handler key. 621 * @param string $display_id 622 * The handler display ID. 623 * @param \Drupal\views\ViewEntityInterface $view 624 * The view being updated. 625 */ 626 public function processEmptyGroupColumn(&$handler, string $handler_type, $key, $display_id, ViewEntityInterface $view): bool { Are we relying on this code to fix views at runtime that are created via the UI. We shouldn't be. I guess we're not otherwise deprecations would be triggered. That means I think we're missing explicit test coverage of this code. Both as an update path and something that triggers deprecations.
Please register or sign in to reply