Skip to content
Snippets Groups Projects

2815881 applying patch #172 against 11.x.

3 unresolved threads

Closes #2815881

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
263 263 unset($fields[$entity_type_key]);
264 264 }
265 265
266 if ($use_groupby) {
266 if ($use_groupby && !empty($this->options['group_column'])) {
  • 298 298 */
    299 299 public function add_field_table($use_groupby) {
    300 300 // Grouping is enabled.
    301 if ($use_groupby) {
    301 if ($use_groupby && !empty($this->options['group_column'])) {
  • 611 *
    612 * Some fields could be saved without a group column, this assures that every
    613 * field has a default group column.
    614 *
    615 * @param array $handler
    616 * A display handler.
    617 * @param string $handler_type
    618 * The handler type.
    619 * @param string $key
    620 * The handler key.
    621 * @param string $display_id
    622 * The handler display ID.
    623 * @param \Drupal\views\ViewEntityInterface $view
    624 * The view being updated.
    625 */
    626 public function processEmptyGroupColumn(&$handler, string $handler_type, $key, $display_id, ViewEntityInterface $view): bool {
    • Are we relying on this code to fix views at runtime that are created via the UI. We shouldn't be. I guess we're not otherwise deprecations would be triggered. That means I think we're missing explicit test coverage of this code. Both as an update path and something that triggers deprecations.

    • Please register or sign in to reply
    Please register or sign in to reply
    Loading