Skip to content
Snippets Groups Projects

3409640 setting height of dialog content in workspace module

Closed 3409640 setting height of dialog content in workspace module
issue/drupal-3409640:3409640-modal-content-not-visible into 11.x
2 unresolved threads
Closed Swati Dhurandhar requested to merge issue/drupal-3409640:3409640-modal-content-not-visible into 11.x
2 unresolved threads

3409640 setting height of dialog content in workspace module

Merge request reports

Merge request pipeline #107919 failed

Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test

Merge request pipeline failed for 01190936

Code Quality is loading
Test summary results are being parsed
Full report

Closed by Théodore BiadalaThéodore Biadala 1 year ago (Mar 4, 2024 9:49am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/workspaces/css/workspaces.off-canvas.pcss.css
18 18 }
19 19 }
20 20
21 & + .ui-dialog .ui-dialog-content {
22 @media (--workspace-layout-small) {
23 max-height: unset !important;
  • Mithun S added 1 commit

    added 1 commit

    • 319f7a5f - Issue-3409640: Add a comment for using important in css for future reference.

    Compare with previous version

  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on an old version of the diff
    • core/modules/workspaces/css/workspaces.off-canvas.pcss.css
    18 18 }
    19 19 }
    20 20
    21 & + .ui-dialog .ui-dialog-content {
    22 @media (--workspace-layout-small) {
    23 max-height: unset !important; /* Override the max-height added by Js. */
  • Mithun S added 1 commit

    added 1 commit

    • adc7a4af - Issue-3409640: Fix the pipeline issue and update the changes as per suggessions.

    Compare with previous version

  • Mithun S added 1 commit

    added 1 commit

    • 01190936 - Issue-3409640: Fix the pipeline issue and address the review comment.

    Compare with previous version

  • Théodore Biadala closed

    closed

    • Please register or sign in to reply