Skip to content
Snippets Groups Projects

2086125 updated last read comment field/filter/argument.

Closes #2086125

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sara Cartee added 1 commit

    added 1 commit

    Compare with previous version

  • Sara Cartee resolved all threads

    resolved all threads

  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • 60 'entity_id' => $entity->id(),
    61 'field_name' => 'comment',
    62 'changed' => \Drupal::time()->getRequestTime() + 3600,
    63 ]);
    64 $comment->setPublished()->save();
    65
    66 $entity = EntityTestMulChanged::create([
    67 'name' => $this->randomString(),
    68 'changed' => \Drupal::time()->getRequestTime() + 7200,
    69 ]);
    70 $entity->save();
    71
    72 $result = views_get_view_result('test_ces_entity_test_mul_changed');
    73 $this->assertEquals($result[0]->comment_entity_statistics_last_updated, $entity->getChangedTime());
    74 $this->assertEquals($result[1]->comment_entity_statistics_last_updated, $comment->getChangedTime());
    75 }
  • We've very close here, mostly some coding style changes for newer code

    And I think we're missing some test coverage

  • Sara Cartee added 1 commit

    added 1 commit

    Compare with previous version

  • Sara Cartee added 1 commit

    added 1 commit

    • f9da8e57 - 2086125 added last updated filter to test.

    Compare with previous version

  • Sara Cartee added 1 commit

    added 1 commit

    • dead1a4e - 2086125 return early instead of using else.

    Compare with previous version

  • Sara Cartee added 1 commit

    added 1 commit

    Compare with previous version

  • Sara Cartee added 1 commit

    added 1 commit

    Compare with previous version

  • J P added 1326 commits

    added 1326 commits

    Compare with previous version

  • Alex Pott added 1640 commits

    added 1640 commits

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 3db90eab - Do not add the StatisticsLastUpdated for entity types without an entity changed date

    Compare with previous version

  • Please register or sign in to reply
    Loading