Skip to content
Snippets Groups Projects

Remove book module from comments

Closes #3409407

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
161 161 * are no remaining fields using them. If multiple modules provide bundles
162 162 * which need to use the same field storage then setting this to TRUE will
163 163 * preserve the field storage regardless of what happens to the bundles. The
164 * classic use case for this is node body field storage since Book, the
165 * Standard profile and bundle (node type) creation through the UI all use
166 * same field storage.
164 * classic use case for this is node body field storage in the Standard
165 * profile and bundle (node type) creation through the UI all use same field
166 * storage.
  • Comment on lines 160 to +166
    Maintainer

    This no longer makes sense grammatically. There are only two things now rather than three, so "all of" doesn't make sense, and the end of the sentence has gone weird with the removal of the word "since". Let's try:

    Suggested change
    160 * By default field storages for configurable fields are removed when there
    161 * are no remaining fields using them. If multiple modules provide bundles
    162 * which need to use the same field storage then setting this to TRUE will
    163 * preserve the field storage regardless of what happens to the bundles. The
    164 * classic use case for this is node body field storage in the Standard
    165 * profile and bundle (node type) creation through the UI all use same field
    166 * storage.
    160 * By default field storages for configurable fields are removed when there
    161 * are no remaining fields using them. If multiple modules provide bundles
    162 * which need to use the same field storage then setting this to TRUE will
    163 * preserve the field storage regardless of what happens to the bundles. The
    164 * classic use case for this is node body field storage, since the Standard
    165 * profile and bundle (node type) creation through the UI both use same field
    166 * storage.

    The whole comment block is a bit wonky, but it's out of scope to fix it. The above minimal changes will at least make the sentence work grammatically.

    Edited by Jess
  • Author Maintainer

    Yes, this change is better. I have added it.

  • Please register or sign in to reply
  • 48 48 * of defining a block.
    49 49 * - \Drupal\user\Plugin\Condition\UserRole is a straightforward example of a
    50 50 * block placement condition plugin.
    51 * - \Drupal\book\Plugin\Block\BookNavigationBlock is an example of a block with
    52 * a custom configuration form.
  • quietone added 1 commit

    added 1 commit

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading