Resolve #2972153 "Deprecate themehandlerinterfacegetbasethemes and"
Closed
requested to merge issue/drupal-2972153:2972153-deprecate-themehandlerinterfacegetbasethemes-and into 11.x
2 unresolved threads
Closes #2972153
Merge request reports
Activity
added 1 commit
- 8c9d48ba - update CR link and add expectDeprecation in test
added 96 commits
-
8c9d48ba...4ca4dbaa - 93 commits from branch
project:11.x
- e1162ad3 - apply patch from comment 6, update deprecation messages
- d17fe548 - add argument $this->root to InfoParser()
- 06b64976 - update CR link and add expectDeprecation in test
Toggle commit list-
8c9d48ba...4ca4dbaa - 93 commits from branch
added 290 commits
-
06b64976...6db12006 - 287 commits from branch
project:11.x
- f2286f72 - apply patch from comment 6, update deprecation messages
- b5ca7eab - add argument $this->root to InfoParser()
- ed978352 - update CR link and add expectDeprecation in test
Toggle commit list-
06b64976...6db12006 - 287 commits from branch
added 277 commits
-
ed978352...27a45227 - 274 commits from branch
project:11.x
- eb7a2ffe - apply patch from comment 6, update deprecation messages
- ab30b1ff - add argument $this->root to InfoParser()
- c8274e32 - update CR link and add expectDeprecation in test
Toggle commit list-
ed978352...27a45227 - 274 commits from branch
143 * The theme name to find all its base themes. 144 * @param array $expected 145 * The expected base themes. 146 * 147 * @dataProvider providerTestDoGetBaseThemes 148 */ 149 public function testDoGetBaseThemes(array $themes, $theme, array $expected) { 150 // Mocks and stubs. 151 $module_handler = $this->prophesize(ModuleHandlerInterface::class); 152 $state = new State(new KeyValueMemoryFactory()); 153 $config_factory = $this->getConfigFactoryStub([]); 154 $theme_engine_list = $this->prophesize(ThemeEngineExtensionList::class); 155 $theme_listing = new ThemeExtensionList($this->root, 'theme', new NullBackend('test'), new InfoParser($this->root), $module_handler->reveal(), $state, $config_factory, $theme_engine_list->reveal(), 'test'); 156 157 $method_to_test = (new \ReflectionObject($theme_listing))->getMethod('doGetBaseThemes'); 158 $method_to_test->setAccessible(TRUE); this no longer needed https://www.drupal.org/project/drupal/issues/3224941
changed this line in version 6 of the diff
132 135 } 133 136 134 137 /** 135 * Provides test data for testGetBaseThemes. 138 * Tests getting the base themes for a set a defines themes. 139 * 140 * @param array $themes 141 * An array of available themes, keyed by the theme name. 142 * @param string $theme 143 * The theme name to find all its base themes. 144 * @param array $expected 145 * The expected base themes. 146 * 147 * @dataProvider providerTestDoGetBaseThemes 148 */ 149 public function testDoGetBaseThemes(array $themes, $theme, array $expected) { changed this line in version 7 of the diff
- Resolved by Dave Long
Please register or sign in to reply