#3261924 Avoid warning from imagecreatefrompng when loading png with obscure iCCP profiles
Merge request reports
Activity
- Resolved by Stephen Mustgrave
added 1 commit
- 47510761 - Move cspell ignore out of the general dictionary to the specific file
- Resolved by Stephen Mustgrave
- Resolved by Stephen Mustgrave
- Resolved by Stephen Mustgrave
added 108 commits
-
9db3cdc5...4ca4dbaa - 107 commits from branch
project:11.x
- a31b0256 - Merge branch drupal:11.x into 11.x
-
9db3cdc5...4ca4dbaa - 107 commits from branch
added 207 commits
-
a31b0256...870e5c1c - 206 commits from branch
project:11.x
- e8ff9201 - Merge branch drupal:11.x into 11.x
-
a31b0256...870e5c1c - 206 commits from branch
added 82 commits
-
e8ff9201...6db12006 - 81 commits from branch
project:11.x
- 6d33f33e - Merge branch '11.x' into '11.x'
-
e8ff9201...6db12006 - 81 commits from branch
added 776 commits
-
6d33f33e...0894355a - 775 commits from branch
project:11.x
- 0d7c89ce - Issue #3261924 by Niklan, jungle, alex.skrypnyk, mudassar774, Rakhi Soni,...
-
6d33f33e...0894355a - 775 commits from branch
added 50 commits
-
0d7c89ce...de44e097 - 49 commits from branch
project:11.x
- 0a08676e - Merge branch '11.x' of https://git.drupalcode.org/project/drupal into 11.x
-
0d7c89ce...de44e097 - 49 commits from branch
added 211 commits
-
0a08676e...c1e7cc2d - 210 commits from branch
project:11.x
- cfdea558 - Merge branch drupal:11.x into 11.x
-
0a08676e...c1e7cc2d - 210 commits from branch
191 191 192 192 // Invalidate the image object and return if the load fails. 193 193 try { 194 $image = $function($this->getSource()); 194 // Suppress warnings from a library action. Some functions can trigger 195 // warnings that are not actionable like loading a PNG content with 196 // certain color profiles. Actual issues with image processing will 197 // trigger exceptions that are logged later on. 198 $image = @$function($this->getSource()); - Comment on lines +194 to +198
We've discussed this quite a bit leading to the comment above the line. I understand why,
@
is almost never the correct answer, so it flags everyone's code smell sensors.The error handler approach is a bit different, though I don't based on how GD triggers these that we'll have good data to log other then.
Regardless, I'm of the opinion these aren't actionable, triggered by automated processes with limited impact, so we are not loosing anything by suppressing them. I don't know of any issues asking for this sort of information and if they did exist that would be a better place to discuss the solution.
added 267 commits
-
4f645847...e63270d5 - 266 commits from branch
project:11.x
- 71ec0daf - Merge branch drupal:11.x into 11.x
-
4f645847...e63270d5 - 266 commits from branch
added 19 commits
-
71ec0daf...fa00b96e - 18 commits from branch
project:11.x
- 6173df27 - Merge branch drupal:11.x into 11.x
-
71ec0daf...fa00b96e - 18 commits from branch
added 127 commits
-
6173df27...ec1b6713 - 126 commits from branch
project:11.x
- 844090d1 - Merge branch drupal:11.x into 11.x
-
6173df27...ec1b6713 - 126 commits from branch