Skip to content
Snippets Groups Projects

Resolve #3406612

Resolve #3406612
issue/drupal-3406612:3406612-js-exceptions-in-batch into 11.x
1 unresolved thread
Closed Ted Bowman requested to merge issue/drupal-3406612:3406612-js-exceptions-in-batch into 11.x
1 unresolved thread

Closes #3406612

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ted Bowman added 1 commit

    added 1 commit

    • 7ae1a69c - Change StatusMessages to have an option to display no messages

    Compare with previous version

  • Ted Bowman resolved all threads

    resolved all threads

  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
    • core/lib/Drupal/Core/Render/Element/StatusMessages.php
    85 87 * @see \Drupal\Core\Messenger\Messenger::deleteByType()
    86 88 */
    87 89 public static function renderMessages($type = NULL) {
    90 if ($type === 'none') {
    91 return [];
    92 }
    • Comment on lines +90 to +92
      Ted Bowman
      Ted Bowman @tedbow ·
      Author Developer

      This the real change it allows a new value for #display in the render array. Currently you can't put a StatusMessages element on the page without it rendering the messages that messages service knows about. The other option I think would be another element type that only added the mark up but didn't render the messages.

      You would think that '#show_messages' => FALSE, which \Drupal\system\Controller\BatchController::batchPage currently adds to the page element would stop this but this not the case. As are as I can tell this only used in \Drupal\Core\Render\BareHtmlPageRenderer::renderBarePage\Drupal\Core\Render\BareHtmlPageRenderer::renderBarePage to determine whether to add its own status messages element.

    • Please register or sign in to reply
  • Ted Bowman closed

    closed

    • Please register or sign in to reply