Issue #3405660: Remove tour from themes
3 unresolved threads
Closes #3405660
Merge request reports
Activity
added 63 commits
-
efd1f0db...d16f4915 - 61 commits from branch
project:11.x - bb4f70e2 - Merge branch '11.x' of git.drupal.org:project/drupal into 3405660-remove-tour-from
- 224f3885 - Address feedback
-
efd1f0db...d16f4915 - 61 commits from branch
added 67 commits
-
224f3885...5bf40faa - 66 commits from branch
project:11.x - 4379132c - Merge branch '11.x' of git.drupal.org:project/drupal into 3405660-remove-tour-from
-
224f3885...5bf40faa - 66 commits from branch
assigned to @quietone
115 115 function tour_tour_update($entity) { 116 116 \Drupal::service('plugin.manager.tour.tip')->clearCachedDefinitions(); 117 117 } 118 119 /** 120 * Implements hook_library_info_alter(). 121 */ 122 function tour_library_info_alter(&$libraries, $extension) { 123 if ($extension === 'tour') { 124 $theme = \Drupal::service('theme.manager')->getActiveTheme()->getName(); 125 if ($theme === 'claro') { 126 $libraries['tour']['dependencies'][] = 'tour/tour-claro-styling'; 127 } 128 elseif ($theme === 'stable9') { 129 $libraries['tour']['dependencies'][] = 'tour/tour-stable9-styling'; 130 } - Comment on lines +123 to +130
-
I can't find anything in→ buttheme.api.phpabout this being computed per theme.\Drupal\Core\Asset\AssetResolver::getCssAssets()clearly does that:// Add the theme name to the cache key since themes may implement
- What about themes whose base theme is
stable9?
-
-
Fixed in 02d4b7bc
added 181 commits
-
ef0ffdbb...501e1ed2 - 179 commits from branch
project:11.x - e70919de - Merge branch '11.x' of git.drupal.org:project/drupal into 3405660-remove-tour-from
- d0204ace - Add base theme
-
ef0ffdbb...501e1ed2 - 179 commits from branch
added 62 commits
-
58632ffd...5ce8edea - 53 commits from branch
project:11.x - c34d68e8 - Issue #3405660: Remove tour from themes
- da27e82c - Fix tests
- 05c60547 - Address feedback
- 742b40e6 - Merge error
- d839855f - Add base theme
- bf35b958 - Update hook
- 02d4b7bc - Fix hook
- 46a75f5d - Fix hook 2
- 53f1c92d - Remove tour from tests
Toggle commit list-
58632ffd...5ce8edea - 53 commits from branch
115 115 function tour_tour_update($entity) { 116 116 \Drupal::service('plugin.manager.tour.tip')->clearCachedDefinitions(); 117 117 } 118 119 /** 120 * Implements hook_library_info_alter(). 121 */ 122 function tour_library_info_alter(&$libraries, $extension) { 123 if ($extension === 'tour') { 124 $theme = \Drupal::service('theme.manager')->getActiveTheme()->getName(); 125 $base_theme = FALSE; 126 if ($theme && !\Drupal::service('theme_handler')->listInfo()[$theme]) { changed this line in version 12 of the diff
added 34 commits
-
53f1c92d...6d9a73fe - 32 commits from branch
project:11.x - 3cd845b1 - Merge branch '11.x' of git.drupal.org:project/drupal into 3405660-remove-tour-from
- b9648548 - Loop through many themes
-
53f1c92d...6d9a73fe - 32 commits from branch
115 115 function tour_tour_update($entity) { 116 116 \Drupal::service('plugin.manager.tour.tip')->clearCachedDefinitions(); 117 117 } 118 119 /** 120 * Implements hook_library_info_alter(). 121 */ 122 function tour_library_info_alter(&$libraries, $extension): void { 123 if ($extension === 'tour') { 124 $themes = []; 125 $current_theme = \Drupal::service('theme.manager')->getActiveTheme()->getName(); 126 $themes[] = $current_theme; 127 if ($current_theme && !\Drupal::service('theme_handler')->listInfo()[$current_theme]) { changed this line in version 13 of the diff
@catch what if we opened a follow up for a new function that retrieves all themes?
added 7 commits
-
b9648548...654b1f20 - 5 commits from branch
project:11.x - 751fe05f - Merge branch '11.x' of git.drupal.org:project/drupal into 3405660-remove-tour-from
- 007596ca - Update
-
b9648548...654b1f20 - 5 commits from branch
Please register or sign in to reply