Issue #3405353: Convert use of TestCase::getName to forward compatible TestCase::name

Closes #3405353

added 1 commit

• d68c2bb6 - Hint name function to phpstan

Compare with previous version

I do not think this is needed. It's never executed in reality since it's in an if (FALSE) { ... } block. It's there for PHPStan not to go beserk. The class alias should suffice.

Yeah technically true, its just providing the stub in a way that's cleaner then adding it to the baseline.

Aha! Let’s add a comment then so some developers are not tempted to remove it later.

Can we say

trait PhpUnitCompatibilityTrait {
  use Drupal\TestTools\PhpUnitCompatibility\PhpUnit9\TestCompatibilityTrait;
}

to extend the existing trait (again only for PHPStan's benefit) instead of copy-pasting code?

Trying that. Should work as long as we do not have multiple version subtraits to manage. On it.

changed this line in version 3 of the diff

added 296 commits

• d68c2bb6...d3c96ddf - 294 commits from branch project:11.x
• 514c5720 - Merge branch '11.x' into 3405353-convert-use-of
• a0d1e809 - fixes

Compare with previous version

added 1 commit

• 55422f04 - fix

Compare with previous version

added 42 commits

• 55422f04...ba4f2951 - 40 commits from branch project:11.x
• 30a4b306 - Merge branch '11.x' into 3405353-convert-use-of
• 4e2f8810 - fixed ScaffoldUpgradeTest

Compare with previous version

added 61 commits

• 4e2f8810...6d9a73fe - 60 commits from branch project:11.x
• 31257ea9 - Merge branch '11.x' into 3405353-convert-use-of

Compare with previous version

added 1 commit

• 43f4fc94 - more finds

Compare with previous version