Issue #2918784: Views RSS row plugin incorrectly assumes links are relative

(cherry picked from commit d122a251)

Closes #2918784

core/modules/views/src/Plugin/views/row/RssFields.php

@@ -2,6 +2,7 @@
 
 namespace Drupal\views\Plugin\views\row;
 
+use Drupal\Component\Utility\UrlHelper;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Url;
 
@@ -130,7 +131,18 @@ public function render($row) {
     // Create the RSS item object.
     $item = new \stdClass();
     $item->title = $this->getField($row_index, $this->options['title_field']);
-    $item->link = $this->getAbsoluteUrl($this->getField($row_index, $this->options['link_field']));
+
+    // If internal link, get absolute URL from URI.
+    $link = $this->getField($row_index, $this->options['link_field']);
+    $link = $link ? trim(strip_tags($link)) : '';
+    if ($link) {
+      if (!UrlHelper::isExternal($link)) {
+        $item->link = $this->getAbsoluteUrl($link);
+      }
+      else {
+        $item->link = Url::fromUri($link)->setAbsolute()->toString();
+      }
+    }
 
     $field = $this->getField($row_index, $this->options['description_field']);
     $item->description = is_array($field) ? $field : ['#markup' => $field];
@@ -147,7 +159,17 @@ public function render($row) {
     $item_guid = $this->getField($row_index, $this->options['guid_field_options']['guid_field']);
     if ($this->options['guid_field_options']['guid_field_is_permalink']) {
       $guid_is_permalink_string = 'true';
-      $item_guid = $this->getAbsoluteUrl($item_guid);
+      $item_guid = $item_guid ? trim(strip_tags($item_guid)) : '';
+
+      // If the guid is an internal link, get the absolute URL from the URI.
+      if ($item_guid) {
+        if (!UrlHelper::isExternal($item_guid)) {
+          $item_guid = $this->getAbsoluteUrl($item_guid);
+        }
+        else {
+          $item_guid = Url::fromUri($item_guid)->setAbsolute()->toString();
+        }
+      }
     }
     $item->elements[] = [
       'key' => 'guid',

[Dave Long]

Why do we need trim and strip_tags? I ran the tests without this and they also pass.

[Michael Vanetta]

Depending on the views configuration, the $this->getField($row_index, $this->options['link_field']); could return markup. In order to use UrlHelper::isExternal($link), this needs to be a clean url.