Issue #3399951: ajax_page_state leaks through request in Views Ajax
2 unresolved threads
Closes #3399951
Merge request reports
Activity
Filter activity
added 82 commits
-
51de138a...2a95e3fd - 81 commits from branch
project:11.x
- 827b13b4 - Issue #3399951: ajax_page_state leaks through request in Views Ajax
-
51de138a...2a95e3fd - 81 commits from branch
added 27 commits
-
827b13b4...127eccde - 23 commits from branch
project:11.x
- 999a4c49 - Issue #3399951: ajax_page_state leaks through request in Views Ajax
- b4aa721d - Consolidate ajax state parameter string into a constant
- 065b323a - Remove extra ajax_page_state workarounds
- 6e997cd4 - Consolidate ajax parameter filtering list
Toggle commit list-
827b13b4...127eccde - 23 commits from branch
- Resolved by catch
- Resolved by catch
- Resolved by Lauri Timmanee
added 98 commits
-
523f4bcb...502c857b - 90 commits from branch
project:11.x
- b477875f - Issue #3399951: ajax_page_state leaks through request in Views Ajax
- 7808f902 - Consolidate ajax state parameter string into a constant
- 96e9537c - Remove extra ajax_page_state workarounds
- b65db7d1 - Consolidate ajax parameter filtering list
- a26ed619 - Apply 1 suggestion(s) to 1 file(s)
- a239c9fb - Apply 1 suggestion(s) to 1 file(s)
- 07d4ac5c - Apply 1 suggestion(s) to 1 file(s)
- 5f24081f - Fix ajax_page_state for theme negotiation.
Toggle commit list-
523f4bcb...502c857b - 90 commits from branch
37 37 */ 38 38 const AJAX_REQUEST_PARAMETER = '_drupal_ajax'; 39 39 40 /** 41 * Request parameter used to track page state. 42 * 43 * This is used to track various page states across ajax requests like the 44 * current theme and available libraries. 45 */ 46 const AJAX_PAGE_STATE_REQUEST_PARAMETER = 'ajax_page_state'; Event subscribers aren't API, so we shouldn't be using this constant elsewhere in the code base.
I think all the usages elsewhere could just go back to using the string as they currently do, feels out of scope for the bugfix. If we want to add a constant, we should add it on an interface or API class somewhere else in a follow-up.
changed this line in version 10 of the diff
added 79 commits
-
d9c878ff...f2daf512 - 70 commits from branch
project:11.x
- d7552391 - Issue #3399951: ajax_page_state leaks through request in Views Ajax
- a14dc6c4 - Consolidate ajax state parameter string into a constant
- e0033bfc - Remove extra ajax_page_state workarounds
- b433e5e7 - Consolidate ajax parameter filtering list
- 0b4338be - Apply 1 suggestion(s) to 1 file(s)
- 64b986b1 - Apply 1 suggestion(s) to 1 file(s)
- ad6456ef - Apply 1 suggestion(s) to 1 file(s)
- 0695d179 - Fix ajax_page_state for theme negotiation.
- 734905ac - Do not use subscriber constants outside its class because it is not API.
Toggle commit list-
d9c878ff...f2daf512 - 70 commits from branch
124 125 } 125 126 127 /** 128 * Tests if exposed filtering via AJAX theme negotiation works. 129 */ 130 public function testExposedFilteringThemeNegotiation(): void { 131 // Install 'claro' and configure it as administrative theme. 132 $this->container->get('theme_installer')->install(['claro']); 133 $this->config('system.theme')->set('admin', 'claro')->save(); 134 135 // Visit the View page. 136 $this->drupalGet('admin/content'); 137 138 // Search for "Page One". 139 $this->submitForm(['title' => 'Page One'], 'Filter'); 140 $this->assertSession()->assertWaitOnAjaxRequest(); changed this line in version 11 of the diff
Please register or sign in to reply