Skip to content
Snippets Groups Projects

Twig Coding Standard Rules

Open Twig Coding Standard Rules
issue/drupal-3284817:3284817-adopt-friendsoftwigtwigcs-for into 11.x
3 unresolved threads
Open Alexandre Dias requested to merge issue/drupal-3284817:3284817-adopt-friendsoftwigtwigcs-for into 11.x
3 unresolved threads

Closes #3284817

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #257944 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3284817

#257947

    Merge request pipeline passed for 193cece7

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.

    Merge details

    • The source branch is 1229 commits behind the target branch.
    • 1 commit will be added to 11.x.
    • Source branch will not be deleted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    composer.json
    12 12 "composer/installers": "^2.0",
    13 13 "drupal/core": "self.version",
    14 14 "drupal/core-project-message": "self.version",
    15 "drupal/core-vendor-hardening": "self.version"
    15 "drupal/core-vendor-hardening": "self.version",
    16 "vincentlanglet/twig-cs-fixer": "^2.1"
  • Alexandre Dias added 204 commits

    added 204 commits

    • 14b26bf2...8705b9ab - 202 commits from branch project:11.x
    • 1f701e18 - Merge remote-tracking branch 'origin/11.x' into 3284817-adopt-friendsoftwigtwigcs-for
    • d1349847 - Move twig-cs-fixer into dev.

    Compare with previous version

  • Alexandre Dias added 1 commit

    added 1 commit

    Compare with previous version

  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on the diff
    • .twig-cs-fixer.php 0 → 100644
    1 <?php
    • Théodore Biadala
      Théodore Biadala @nod_
      Maintainer

      we try to avoid adding too much dot files here, most of them are under core/, the CLI has an option to define a config file when executing.

      Or have this file do an include of the one under core/

    • Please register or sign in to reply
  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on the diff
    • .gitlab-ci.yml
    494 494 $impact = array_map(fn (float $h, float $m) => $m-$h, $head, $mr);
    495 495 exit((int) (min($impact) < 0));
    496 496 '
    497
    498 '🧹 Twig Coding Standard (twig-cs-fixer)':
    499 <<: [ *with-composer, *default-job-settings-lint ]
    500 stage: 🪄 Lint
    501 variables:
    502 KUBERNETES_CPU_REQUEST: "16"
    503 script:
    504 - php vendor/bin/twig-cs-fixer lint > twig-cs-quality-report.json
    505 artifacts:
    506 reports:
    507 codequality: twig-cs-quality-report.json
  • Théodore Biadala requested changes

    requested changes

    • Please register or sign in to reply