Fix modal width
6 unresolved threads
6 unresolved threads
Merge request reports
Activity
added 14 commits
-
a2e95fe5...c6b47e6a - 12 commits from branch
project:11.x
- 48c4d7f6 - Fix modal width
- 57ce8717 - Added test
-
a2e95fe5...c6b47e6a - 12 commits from branch
added 11 commits
-
57ce8717...27f9fa66 - 9 commits from branch
project:11.x
- c900fcc2 - Fix modal width
- 14d291f8 - Added test
-
57ce8717...27f9fa66 - 9 commits from branch
102 102 } 103 103 adjustedOptions[option] = adjustedValue; 104 104 } 105 if ( 106 option === 'width' && 107 parseInt(optionValue, 10) > $(window).width() changed this line in version 4 of the diff
added 75 commits
-
14d291f8...910b569f - 72 commits from branch
project:11.x
- 7e3975e0 - Fix modal width
- 0753fc58 - Added test
- dbac2720 - Added offset check as well
Toggle commit list-
14d291f8...910b569f - 72 commits from branch
102 102 } 103 103 adjustedOptions[option] = adjustedValue; 104 104 } 105 if ( 106 option === 'width' && 107 parseInt(optionValue, 10) > 108 $(window).width() - (displace.offsets.left + displace.offsets.right) 109 ) { 110 adjustedValue = $(window).width() - 40; changed this line in version 5 of the diff
added 1 commit
- ed38845b - Added offset check as to new width calculation
added 1 commit
- 615ce268 - Added the code that restores the modal size if we switch back to fullscreen mode
102 102 } 103 103 adjustedOptions[option] = adjustedValue; 104 104 } 105 if ( 106 option === 'width' && 107 parseInt(optionValue, 10) > $(window).width() 108 ) { 109 if (!event.data.settings.modal) { 110 adjustedValue = 111 $(window).width() - 112 40 - 113 (displace.offsets.left + displace.offsets.right); changed this line in version 10 of the diff
106 option === 'width' && 107 parseInt(optionValue, 10) > $(window).width() 108 ) { 109 if (!event.data.settings.modal) { 110 adjustedValue = 111 $(window).width() - 112 40 - 113 (displace.offsets.left + displace.offsets.right); 114 } else { 115 adjustedValue = $(window).width() - 40; 116 } 117 adjustedOptions[option] = adjustedValue; 118 } 119 if ( 120 option === 'width' && 121 $(window).width() > parseInt(optionValue, 10) changed this line in version 9 of the diff
78 * Tests dialog resizing on window resize. 79 */ 80 public function testModalWidthResizing() { 81 $this->drupalGet('entity_test/structure/entity_test/fields'); 82 $page = $this->getSession()->getPage(); 83 84 $page->pressButton('List additional actions'); 85 $page->findLink('Delete')->click(); 86 $this->assertSession()->assertWaitOnAjaxRequest(); 87 88 // Resize the window. 89 $this->getSession()->resizeWindow(785, 805); 90 $dialog = $page->find('css', '[role="dialog"]'); 91 $dialog_style = $dialog->getAttribute('style'); 92 // Assert that the width has been adjusted on window resize. 93 $this->assertStringContainsString('width: 745', $dialog_style); 102 102 } 103 103 adjustedOptions[option] = adjustedValue; 104 104 } 105 if ( 106 option === 'width' && 107 parseInt(optionValue, 10) > $(window).width() changed this line in version 9 of the diff
added 26 commits
-
de104d03...d5d6431e - 17 commits from branch
project:11.x
- d372d4a1 - Fix modal width
- f3f40974 - Added test
- e7f2567c - Added offset check as well
- 4b822ea0 - Added offset check as to new width calculation
- 0c4e394f - Added the code that restores the modal size if we switch back to fullscreen mode
- 16229061 - WIP
- 54949a18 - Addressed feedbacks
- aa33da17 - Restructured conditional statements
- b02261dc - Added test coverage for switching to fullscreen
Toggle commit list-
de104d03...d5d6431e - 17 commits from branch
added 73 commits
-
663dc2e4...27c6d955 - 63 commits from branch
project:11.x
- fdaa7d22 - Fix modal width
- 9f06becd - Added test
- 9408e53a - Added offset check as well
- 21b16df9 - Added offset check as to new width calculation
- 6caf6aa4 - Added the code that restores the modal size if we switch back to fullscreen mode
- 04222607 - WIP
- c63cc455 - Addressed feedbacks
- 35b1c4b5 - Restructured conditional statements
- 721ed268 - Added test coverage for switching to fullscreen
- c7353a1c - Fixed tests
Toggle commit list-
663dc2e4...27c6d955 - 63 commits from branch
Please register or sign in to reply