Skip to content
Snippets Groups Projects

Add explicit test coverage.

Closes #3396628

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 57 $settings = $before['test_format_list_ol_start']->getSettings();
    58 $this->assertArrayHasKey('ckeditor5_list', $settings['plugins']);
    59 $this->assertSame(['<ol start foo>'], $settings['plugins']['ckeditor5_sourceEditing']['allowed_tags']);
    60
    61 // test_text_format before: not using the List plugin.
    62 $settings = $before['test_text_format']->getSettings();
    63 $this->assertArrayNotHasKey('ckeditor5_list', $settings['plugins']);
    64
    65 $this->runUpdates();
    66
    67 $after = Editor::loadMultiple();
    68
    69 // Basic HTML after: reversed=FALSE, startIndex=FALSE, Source Editing
    70 // configuration unchanged.
    71 $settings = $after['basic_html']->getSettings();
    72 $this->assertSame(['reversed' => FALSE, 'startIndex' => FALSE], $settings['plugins']['ckeditor5_list']);
  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers added 48 commits

    added 48 commits

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • dc8495a0 - PHPStorm reformatted things during conflict resolution :grimacing:

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 99056b11 - Thanks to the recently added `CKEditor5UpdateListMultiBlockTest`, I discovered...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 0178b83a - I did not properly test the previous commit apparently :see_no_evil:

    Compare with previous version

  • 1 <?php
    2
    3 declare(strict_types=1);
    4
    5 namespace Drupal\Tests\ckeditor5\Functional\Update;
    6
    7 use Drupal\ckeditor5\HTMLRestrictions;
    8 use Drupal\editor\Entity\Editor;
    9 use Drupal\FunctionalTests\Update\UpdatePathTestBase;
    10
    11 /**
    12 * @covers ckeditor5_post_update_list_start_reversed
    13 * @group Update
    14 * @group ckeditor5
    15 */
    16 class CKEditor5UpdateIOlStartReversed extends UpdatePathTestBase {
  • 49 49 - '<a hreflang>'
    50 50 - '<blockquote cite>'
    51 51 - '<ul type>'
    52 - '<ol start type>'
    52 - '<ol type>'
  • 544 544 ],
    545 545 'violations' => [],
    546 546 ];
    547 $data['INVALID: SourceEditing plugin configuration: <ol start type> must not be allowed because List can generate <ol start>'] = [
    548 'settings' => [
    549 'toolbar' => [
    550 'items' => [
    551 'numberedList',
    552 'sourceEditing',
    553 ],
    554 ],
    555 'plugins' => [
    556 'ckeditor5_list' => [
    557 'properties' => [
    558 'reversed' => TRUE,
    559 'startIndex' => TRUE,
  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • eae77439 - Tighten `SourceEditingRedundantTagsConstraintValidator`, Umami tests should fail now.

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading