Add explicit test coverage.
Open
requested to merge issue/drupal-3396628:3396628-tighten-sourceeditingredundanttagsconstraintvalidator into 11.x
Closes #3396628
Merge request reports
Activity
added 1 commit
- 9e66393c - Fix default config in Standard install profile.
added 1 commit
- 17fbedc9 - Restore the deleted code, but with a narrower condition and a much easier to understand comment.
added 1 commit
- Resolved by Wim Leers
57 $settings = $before['test_format_list_ol_start']->getSettings(); 58 $this->assertArrayHasKey('ckeditor5_list', $settings['plugins']); 59 $this->assertSame(['<ol start foo>'], $settings['plugins']['ckeditor5_sourceEditing']['allowed_tags']); 60 61 // test_text_format before: not using the List plugin. 62 $settings = $before['test_text_format']->getSettings(); 63 $this->assertArrayNotHasKey('ckeditor5_list', $settings['plugins']); 64 65 $this->runUpdates(); 66 67 $after = Editor::loadMultiple(); 68 69 // Basic HTML after: reversed=FALSE, startIndex=FALSE, Source Editing 70 // configuration unchanged. 71 $settings = $after['basic_html']->getSettings(); 72 $this->assertSame(['reversed' => FALSE, 'startIndex' => FALSE], $settings['plugins']['ckeditor5_list']); changed this line in version 11 of the diff
added 48 commits
-
6984a8ac...c1a42fda - 47 commits from branch
project:11.x
- d2c1d0e9 - Merge remote-tracking branch 'origin/11.x' into...
-
6984a8ac...c1a42fda - 47 commits from branch
added 1 commit
-
dc8495a0 - PHPStorm reformatted things during conflict resolution
-
dc8495a0 - PHPStorm reformatted things during conflict resolution
added 1 commit
added 1 commit
- 99056b11 - Thanks to the recently added `CKEditor5UpdateListMultiBlockTest`, I discovered...
added 1 commit
-
0178b83a - I did not properly test the previous commit apparently
-
0178b83a - I did not properly test the previous commit apparently
1 <?php 2 3 declare(strict_types=1); 4 5 namespace Drupal\Tests\ckeditor5\Functional\Update; 6 7 use Drupal\ckeditor5\HTMLRestrictions; 8 use Drupal\editor\Entity\Editor; 9 use Drupal\FunctionalTests\Update\UpdatePathTestBase; 10 11 /** 12 * @covers ckeditor5_post_update_list_start_reversed 13 * @group Update 14 * @group ckeditor5 15 */ 16 class CKEditor5UpdateIOlStartReversed extends UpdatePathTestBase { changed this line in version 14 of the diff
49 49 - '<a hreflang>' 50 50 - '<blockquote cite>' 51 51 - '<ul type>' 52 - '<ol start type>' 52 - '<ol type>' 544 544 ], 545 545 'violations' => [], 546 546 ]; 547 $data['INVALID: SourceEditing plugin configuration: <ol start type> must not be allowed because List can generate <ol start>'] = [ 548 'settings' => [ 549 'toolbar' => [ 550 'items' => [ 551 'numberedList', 552 'sourceEditing', 553 ], 554 ], 555 'plugins' => [ 556 'ckeditor5_list' => [ 557 'properties' => [ 558 'reversed' => TRUE, 559 'startIndex' => TRUE, I can't recall if that's the intended behavior.
It wasn't! See my research at https://www.drupal.org/project/drupal/issues/3396628#comment-15290242 — it's related to how the validation logic predates the whole
<tag>
vs<tag attr>
thing that #3273983 introduced.Please see the changes in
SourceEditingRedundantTagsConstraintValidator
— that's ensuring that this will never happen again
added 1 commit
added 1 commit
- eae77439 - Tighten `SourceEditingRedundantTagsConstraintValidator`, Umami tests should fail now.
Please register or sign in to reply