Issue #3096092: Make "path_alias" module optional
Merge request reports
Activity
added 2 commits
- core/modules/path_alias/path_alias.module 0 → 100644
8 declare(strict_types = 1); 9 10 use Drupal\Core\Routing\RouteMatchInterface; 11 use Drupal\path_alias\Form\SystemInformationFormAlter; 12 13 /** 14 * Implements hook_help(). 15 */ 16 function path_alias_help($route_name, RouteMatchInterface $route_match): string { 17 switch ($route_name) { 18 case 'help.page.path_alias': 19 $output = ''; 20 $output .= '<h3>' . t('About') . '</h3>'; 21 // @todo put something meaningful here. 22 $output .= '<p>' . t('The Path alias module foo bar baz') . '</p>'; 23 $output .= '<p>' . t('For more information, see the <a href=":path_alias">online documentation for the Path alias module</a>.', [':path_alias' => 'https://www.drupal.org/documentation/modules/path_alias']); 51 * @param \Drupal\Core\Path\PathValidatorInterface $path_validator 42 * @param \Drupal\Core\Path\PathValidatorInterface|\Drupal\path_alias\AliasManagerInterface $path_validator 52 43 * The path validator. 53 * @param \Drupal\Core\Routing\RequestContext $request_context 44 * @param \Drupal\Core\Routing\RequestContext|\Drupal\Core\Path\PathValidatorInterface $request_context 54 45 * The request context. 55 46 */ 56 public function __construct(ConfigFactoryInterface $config_factory, TypedConfigManagerInterface $typedConfigManager, AliasManagerInterface $alias_manager, PathValidatorInterface $path_validator, RequestContext $request_context) { 47 public function __construct(ConfigFactoryInterface $config_factory, TypedConfigManagerInterface $typedConfigManager, PathValidatorInterface|AliasManagerInterface $path_validator, RequestContext|PathValidatorInterface $request_context) { 57 48 parent::__construct($config_factory, $typedConfigManager); 58 $this->aliasManager = $alias_manager; 49 if ($path_validator instanceof AliasManagerInterface) { 50 @trigger_error('Calling ' . __CLASS__ . '::__construct() with the $alias_manager argument is deprecated in drupal:10.2.0 and is removed in drupal:11.0.0. See https://www.drupal.org/node/3096092', E_USER_DEPRECATED); 51 $path_validator = func_get_arg(3); 52 $request_context = func_get_arg(4); 53 } 1 <?php 2 3 declare(strict_types = 1); 4 5 namespace Drupal\path_alias\Form; 6 7 use Drupal\Core\DependencyInjection\ContainerInjectionInterface; 8 use Drupal\Core\DependencyInjection\DependencySerializationTrait; 9 use Drupal\Core\Form\FormStateInterface; 10 use Drupal\path_alias\AliasManagerInterface; 11 use Symfony\Component\DependencyInjection\ContainerInterface; 12 13 /** 14 * Alteration class for the site information settings form. 15 */ 16 class SystemInformationFormAlter implements ContainerInjectionInterface { Closest I could find was
\Drupal\Tests\system\Functional\System\FrontPageTest::testDrupalFrontPage
. I'm wondering if some of that can be achieved with config schema validation.I couldn't find any tests that are actually setting the paths in
system.site.page
to an alias, so we probably need to add some here.changed this line in version 14 of the diff
- Resolved by Michael Strelan
added 92 commits
-
08ca0ded...666f9e98 - 75 commits from branch
project:11.x
- 666f9e98...b3ce0d27 - 7 earlier commits
- 7170e2eb - Add path_alias to standard and demo_umami
- cbcb03d8 - Make DistributionProfileTest pass
- 5f9df88b - Fix PathEncodedTest
- 0875bc30 - Fix tests that use PathAliasTestTrait
- 53476460 - Fix LanguageSwitchingTest
- 20c67792 - Attempt to make RequestPath work without path_alias
- 9d841e44 - Implement hook_help
- 103b70a8 - Remove path_alias special handling from ConfigImportAllTest
- 716cd08f - Enable path_alias when enabling views
- c0f2d202 - Remove aliasManager from RequestPath
Toggle commit list-
08ca0ded...666f9e98 - 75 commits from branch
added 164 commits
-
c0f2d202...5d011419 - 147 commits from branch
project:11.x
- 5d011419...baac3641 - 7 earlier commits
- 10301758 - Add path_alias to standard and demo_umami
- 7f2f1cc0 - Make DistributionProfileTest pass
- 2b76c068 - Fix PathEncodedTest
- 9cf0209e - Fix tests that use PathAliasTestTrait
- 1a9a70bc - Attempt to make RequestPath work without path_alias
- 63a5929a - Implement hook_help
- 6f56d699 - Remove path_alias special handling from ConfigImportAllTest
- 81f0cb98 - Enable path_alias when enabling views
- b20d53cd - Remove aliasManager from RequestPath
- b4a34189 - Issue #3096092: Fixed conflict.
Toggle commit list-
c0f2d202...5d011419 - 147 commits from branch
added 158 commits
-
b4a34189...3ae37397 - 141 commits from branch
project:11.x
- 3ae37397...66f8d289 - 7 earlier commits
- 9e8bb92f - Add path_alias to standard and demo_umami
- 9f174889 - Make DistributionProfileTest pass
- 43ee855e - Fix PathEncodedTest
- 519ba083 - Fix tests that use PathAliasTestTrait
- 2adaac1c - Fix LanguageSwitchingTest
- 55d288ba - Attempt to make RequestPath work without path_alias
- ea8a8d55 - Implement hook_help
- 335d7d9b - Remove path_alias special handling from ConfigImportAllTest
- 23f86e5d - Enable path_alias when enabling views
- e90aad32 - Remove aliasManager from RequestPath
Toggle commit list-
b4a34189...3ae37397 - 141 commits from branch
Please register or sign in to reply