Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
drupal
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
drupal
Merge requests
!5005
Issue
#3280848
: Shortcut links without a title cause deprecation notices.
Code
Review changes
Check out branch
Download
Patches
Plain diff
Open
Issue
#3280848
: Shortcut links without a title cause deprecation notices.
issue/drupal-3280848:3280848-shortcut-error
into
11.x
Overview
25
Commits
13
Pipelines
19
Changes
7
Open
Stephen Mustgrave
requested to merge
issue/drupal-3280848:3280848-shortcut-error
into
11.x
1 year ago
Overview
19
Commits
13
Pipelines
19
Changes
7
Expand
0
0
Merge request reports
Compare
11.x
version 18
54b138d8
1 year ago
version 17
344ff934
1 year ago
version 16
b1b80927
1 year ago
version 15
0c92ec31
1 year ago
version 14
be585ad9
1 year ago
version 13
d4cde09c
1 year ago
version 12
6460de90
1 year ago
version 11
2ffb1fa6
1 year ago
version 10
601bee88
1 year ago
version 9
7c5e459e
1 year ago
version 8
51d614c4
1 year ago
version 7
1171f19a
1 year ago
version 6
94d547ca
1 year ago
version 5
717d91ce
1 year ago
version 4
2f19e89d
1 year ago
version 3
40cd8a27
1 year ago
version 2
b6d2e62e
1 year ago
version 1
7a0c01cf
1 year ago
11.x (HEAD)
and
latest version
latest version
8e3ff904
13 commits,
1 year ago
version 18
54b138d8
12 commits,
1 year ago
version 17
344ff934
11 commits,
1 year ago
version 16
b1b80927
10 commits,
1 year ago
version 15
0c92ec31
9 commits,
1 year ago
version 14
be585ad9
8 commits,
1 year ago
version 13
d4cde09c
7 commits,
1 year ago
version 12
6460de90
6 commits,
1 year ago
version 11
2ffb1fa6
5 commits,
1 year ago
version 10
601bee88
4 commits,
1 year ago
version 9
7c5e459e
3 commits,
1 year ago
version 8
51d614c4
194 commits,
1 year ago
version 7
1171f19a
191 commits,
1 year ago
version 6
94d547ca
188 commits,
1 year ago
version 5
717d91ce
187 commits,
1 year ago
version 4
2f19e89d
186 commits,
1 year ago
version 3
40cd8a27
3 commits,
1 year ago
version 2
b6d2e62e
2 commits,
1 year ago
version 1
7a0c01cf
1 commit,
1 year ago
7 files
+
138
−
2
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
7
Search (e.g. *.vue) (Ctrl+P)
core/modules/shortcut/src/Controller/ShortcutSetController.php
+
2
−
1
Options
@@ -45,7 +45,8 @@ public function __construct(PathValidatorInterface $path_validator) {
*/
public
function
addShortcutLinkInline
(
ShortcutSetInterface
$shortcut_set
,
Request
$request
)
{
$link
=
$request
->
query
->
get
(
'link'
);
$name
=
$request
->
query
->
get
(
'name'
);
$name
=
!
empty
(
$request
->
query
->
get
(
'name'
))
?
$request
->
query
->
get
(
'name'
)
:
'('
.
$this
->
t
(
'Empty'
,
[],
[
'langcode'
=>
$shortcut_set
->
language
()
->
getId
()])
.
')'
;
if
(
parse_url
(
$link
,
PHP_URL_SCHEME
)
===
NULL
&&
$this
->
pathValidator
->
isValid
(
$link
))
{
$shortcut
=
$this
->
entityTypeManager
()
->
getStorage
(
'shortcut'
)
->
create
([
'title'
=>
$name
,
Loading