Skip to content
Snippets Groups Projects

Issue #3392196: Exceptions in batch no longer are shown on the page

Open Issue #3392196: Exceptions in batch no longer are shown on the page
issue/drupal-3392196:3392196-exceptions-in-batch into 11.x
1 unresolved thread
Open Ted Bowman requested to merge issue/drupal-3392196:3392196-exceptions-in-batch into 11.x
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/system/src/Controller/BatchController.php
55 55 return $output;
56 56 }
57 57 elseif (isset($output)) {
58 $output['batch_messages'] = [
59 '#type' => 'status_messages',
60 '#include_fallback' => TRUE,
61 ];
  • Comment on lines +58 to +61
    Ted Bowman
    Ted Bowman @tedbow
    Author Developer

    Ok. This makes the JS test on this issue pass but makes other functional tests fail.

    for example \Drupal\Tests\locale\Functional\LocaleImportFunctionalTest::testStandalonePoFile fails because it expects a messages to be on the page after the batch process. in 11.x I think any calls to messages via the messenger service will not get rendered until after the batch process. But add this seems to override '#show_messages' => FALSE, below.

    it does make sense to not show the messages until after but also that we want the JS call back error to show up on the page.

  • Please register or sign in to reply
  • Adam G-H added 2 commits

    added 2 commits

    Compare with previous version

  • Ted Bowman added 307 commits

    added 307 commits

    Compare with previous version

    Toggle commit list
    • Please register or sign in to reply