Convey AJAX progress messages to assistive technology. - #2973140
5 unresolved threads
Closes #2973140
Merge request reports
Activity
added 103 commits
-
fa1f1a6b...f91e76e5 - 101 commits from branch
project:11.x
- 2bc00ac4 - Convey AJAX progress messages to assistive technology. - #2973140
- 6ea1e592 - Removed console.
-
fa1f1a6b...f91e76e5 - 101 commits from branch
added 2273 commits
Toggle commit list435 435 schemaapi 436 436 schemeless 437 437 scorewords 438 screenreaders changed this line in version 7 of the diff
424 424 } 425 425 426 // Set default values for progress' screen reader properties. 427 // The 'announce' property determines if screenreaders should announce 428 // progress for this operation. 429 // The 'announceDelay' property is how many milliseconds must pass before 430 // AJAX progress is announced by a screen reader. This prevents announcing 431 // operations that are completed quickly enough that an announcement is 432 // not necessary or useful. 433 // The 'announceIntervalTime' property is how many milliseconds must 434 // pass before the operation is re-announced. This provides a way to 435 // distinguish an operation in progress vs an operation that did not\ 436 // complete. 437 // The 'announceMessage' property is what is used if no 'message' 438 // property is present. 439 if (isset($settings['progress'])) { 919 919 typeof this[progressIndicatorMethod] === 'function' 920 920 ) { 921 921 this[progressIndicatorMethod].call(this); 922 923 // To avoid very fast AJAX operations from being announced, wait for the 924 // duration of the announceDelay property (1 second by default) before 925 // announcing progress to screenreaders. 926 const delay = this.progress.announceDelay || 1000; 927 setTimeout(() => { 928 // Note that the disabling of $(this.element) is a pre-existing 929 // implementation used to prevent interaction while the request is in 930 // progress. It is being leveraged here as a way to confirm the AJAX 931 // operation completed as nothing else is available in scope to do so. 932 const shouldAnnounce = this.progress.hasOwnProperty('announce') added 1 commit
- 1315cb7c - Add JavaScript tests for progress announcement
added 540 commits
-
1315cb7c...73613e52 - 532 commits from branch
project:11.x
- 062de715 - Convey AJAX progress messages to assistive technology. - #2973140
- 298aefb0 - Removed console.
- 256ca6eb - Removed Big pipe regression test change
- 210cfad0 - Added `screenreaders` to dictionary
- ca2e3c6e - Remove "screenreaders" from dictionary
- 277ee3bb - Create kernel tests for announce settings
- ee0e887e - Add return type to test function
- 6656c3bc - Add JavaScript tests for progress announcement
Toggle commit list-
1315cb7c...73613e52 - 532 commits from branch
added 1 commit
- 91367f9e - Fix namespace typo in AjaxProgressAnnounceTest
added 24 commits
-
91367f9e...a0a7640c - 15 commits from branch
project:11.x
- 77539efd - Convey AJAX progress messages to assistive technology. - #2973140
- cec6047d - Removed console.
- f8255ec6 - Removed Big pipe regression test change
- b6918ec8 - Added `screenreaders` to dictionary
- 57c9a1c6 - Remove "screenreaders" from dictionary
- 5939b40e - Create kernel tests for announce settings
- 7564da0f - Add return type to test function
- 11b47a53 - Add JavaScript tests for progress announcement
- c38dcfcb - Fix namespace typo in AjaxProgressAnnounceTest
Toggle commit list-
91367f9e...a0a7640c - 15 commits from branch
35 35 '#markup' => '<p>' . $this->t("Ajax Form contents description.") . '</p>', 36 36 ]; 37 37 38 $form['select'] = [ 39 '#type' => 'select', 40 '#title' => 'AJAX Select field', 41 '#options' => [ This may have broken a test. The
Actual
value in the failure message looks like these new#options
values.Dialog (Drupal\FunctionalJavascriptTests\Ajax\Dialog) ✘ Dialog ┐ ├ Failed asserting that two strings are equal. ┊ ---·Expected ┊ +++·Actual ┊ @@ @@ ┊ -'Do·it' ┊ +'\n ┊ +············One\n ┊ +················Two\n ┊ +······' │ │ /builds/issue/drupal-2973140/core/tests/Drupal/FunctionalJavascriptTests/Ajax/DialogTest.php:192 ┴
Other pipeline failures are performance tests comparing the size of received scripts. The tests might need updating to expect the new values for
ScriptBytes
.I believe these are the tests, based on the pipeline failure messages. The new values for
ScriptBytes
probably need to be the values in the failure messages.- OpenTelemetryAuthenticatedPerformanceTest.php#L68
- AssetAggregationAcrossPagesTest.php#L51
- AssetAggregationAcrossPagesTest.php#L72
[Edited to correct line number]
Edited by Kent Richards
Please register or sign in to reply