Issue #3389510: Split up update semver tests

added 2 commits

• d34c9d4d - Add @group #slow
• e0c53c4f - Remove unused use statements.

Compare with previous version

added 1 commit

• 21f069af - Use the right trait.

Compare with previous version

added 1 commit

• 86b55d81 - Add group #slow

Compare with previous version

We now have 6 overrides of this. 2 are exactly the same for contrib and 4 are exactly the same for core. I think this will be hard to keep in-sync in the future.

Could we just make this non-abstract like this

protected function setProjectInstalledVersion($version) {
  if ($this->updateProject !== 'drupal') {
    $this->mockInstalledExtensionsInfo([
      $this->updateProject => [
        'project' => $this->updateProject,
        'version' => $version,
        'hidden' => FALSE,
      ],
      // Ensure Drupal core on the same version for all test runs.
      'drupal' => [
        'project' => 'drupal',
        'version' => '8.0.0',
        'hidden' => FALSE,
      ],
    ]);
    $this->mockDefaultExtensionsInfo(['version' => '8.0.0']);
  }
  else {
    $this->mockDefaultExtensionsInfo(['version' => $version]);
  }
}

Then we would not need any overrides

Actually I made 2 base classes to avoid other duplication in addition. So now this just has 2 overrides.

added 5 commits

• b157c5fe - no override setProjectVErsion
• 5edc690c - works
• c7068b61 - 2 bases to reduce duplication
• a9532291 - make setProjectInstalledVersion abstract again
• ef058fa8 - phpcbf

Compare with previous version

added 16 commits

• ef058fa8...f71ac74e - 6 commits from branch project:11.x
• 513c40bc - Refactor Update Semver tests into logical grouping so that each test class can...
• cb645bca - Add @group #slow
• f61a5255 - Remove unused use statements.
• 32ad9462 - Use the right trait.
• b7b13aba - Add group #slow
• 4c8c2ac1 - no override setProjectVErsion
• 005271f7 - works
• db12b1e8 - 2 bases to reduce duplication
• e3532089 - make setProjectInstalledVersion abstract again
• 1c2c6fcb - phpcbf

Compare with previous version

added 1 commit

• f3b3c215 - Add class summary docs.

Compare with previous version

added 36 commits

• f3b3c215...d0cfc6d0 - 24 commits from branch project:11.x
• d0cfc6d0...62f50691 - 2 earlier commits
• 580f4867 - Remove unused use statements.
• c60ca2f7 - Use the right trait.
• 7199027b - Add group #slow
• 5702eb5c - no override setProjectVErsion
• c76b83aa - works
• ee019d0b - 2 bases to reduce duplication
• 303d237c - make setProjectInstalledVersion abstract again
• a3e3f332 - phpcbf
• 7f239cf5 - Add class summary docs.
• a614a2c8 - [#3389510]: Fix all file comments to actually explain what's happening.

Compare with previous version

added 23 commits

• a614a2c8...426bcc3b - 11 commits from branch project:11.x
• 426bcc3b...3cd413b3 - 2 earlier commits
• dc91a843 - Remove unused use statements.
• a95d1009 - Use the right trait.
• 0558f097 - Add group #slow
• 5af97d70 - no override setProjectVErsion
• 717a678e - works
• edaf5ed8 - 2 bases to reduce duplication
• cb699384 - make setProjectInstalledVersion abstract again
• f755a59f - phpcbf
• b7b397d7 - Add class summary docs.
• f4bf78fa - [#3389510]: Fix all file comments to actually explain what's happening.

Compare with previous version

closed