Skip to content
Snippets Groups Projects

Issue #3387039: Large placeholders are not processed

1 unresolved thread
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Théodore Biadala
  • 69 69 return;
    70 70 }
    71 71
    72 // Immediately remove the replacement to prevent it being processed twice.
    73 delete drupalSettings.bigPipePlaceholderIds[id];
    74
    75 72 const response = mapTextContentToAjaxResponse(content);
    76 73
    77 74 if (response === false) {
    78 75 return;
    79 76 }
    80 77
    78 // Immediately remove the replacement to prevent it being processed twice.
    79 delete drupalSettings.bigPipePlaceholderIds[id];
    • moving that here means that fully loaded nodes with invalid json could still be processed at some point, not sure it's a problem since we shouldn't try to process things more than once, but pointing it out just in case.

    • If we do not move it here then we will not be able to track if the chunk was not processed during characterData mutation observer triggering.

      Leaving a chunk of code, just to make sure ctrl + f can work in case when the link will be invalid.

      drupalSettings.bigPipePlaceholderIds[ target.parentNode.dataset.bigPipeReplacementForPlaceholderWithId ] === true

    • Please register or sign in to reply
  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading