Issue #3365497: Create new SDC component for Umami Banner
Merge request reports
Activity
added 1 commit
3 3 * This file is used to style the banner block. 4 4 */ 5 5 6 .banner-block__content { 6 .banner__content { 7 7 margin: 1rem 4%; 8 8 font-size: 1.188em; 9 9 } 10 10 11 .banner-block .field--name-field-title { 11 .banner .field--name-field-title { -
Sorry for the nitpickines. We should probably avoid Field related markup & classes inside components. This data might come from anywhere.
Moreover, if you make
imagea slot, you cannot rely on the contents of the slot to have these very specific classes. Maybe a sub-component may be in order here? 
i'm thinking about porting that
Titlecomponent from cards MR and creating newButtoncomponent.changed this line in version 4 of the diff
1 <div class="banner"> 2 <div class="banner__inner"> 3 <div class="banner__image"> 4 {% block image %}{% endblock %} 5 </div> changed this line in version 17 of the diff
31 'banner-block', 32 'block', 33 'block-' ~ configuration.provider|clean_class, 34 'block-' ~ plugin_id|clean_class, 35 ] 36 %} 37 38 <div{{attributes.addClass(classes)}}> 39 <div class="banner-block__inner"> 40 {{ title_prefix }} 41 {% if label %} 42 <h2{{title_attributes}}>{{ label }}</h2> 43 {% endif %} 44 {{ title_suffix }} 30 {% block content %} 31 {% embed 'umami:banner' %} changed this line in version 16 of the diff
Please register or sign in to reply