Resolve #3209192 "Starterkit theme add"
Closes #3209192
Merge request reports
Activity
added 1 commit
- Resolved by Matthieu Scarset
This looks great. 2 tiny typo fixes and then ready RTBC from me.
- Last reply by Matthieu Scarset
-
(OMG) I realized I didnt submit a comment I made weeks ago...
Anyway, as requested, I have undo the changes I made to
GenerateCommand.php.I think it is not ideal to ship the starterkit_theme this way because there are too much things to change manually (JS filename, library name...etc) but I understand the point that the script is being rewritten.
In case we change our mind, I'll be more than happy to re-apply my previous changes to make the generate command more helpful for onboarding developers/themers.
added 88 commits
-
2c6293c1...75a15bb8 - 79 commits from branch
project:11.x - ddb70dcf - Example JS behavior in starterkit_theme #3209192
- 47825190 - Add comment about element selector #3209192
- 92ba0c2d - Fix coding standard #3209192
- 265561fd - Fix coding standard (JS) #3209192
- fea00e31 - Fix typo #3209192
- 36f671dc - More detailed comments #3209192
- ed412948 - Revert changes to GenerateTheme #3209192
- c80436cf - Fix coding standard #3209192
- edf80c30 - fixed typo
Toggle commit list-
2c6293c1...75a15bb8 - 79 commits from branch
Please register or sign in to reply