Resolve #3209192 "Starterkit theme add"
Closes #3209192
Merge request reports
Activity
added 1 commit
- Resolved by Matthieu Scarset
- Resolved by Matthieu Scarset
- Resolved by Matthieu Scarset
This looks great. 2 tiny typo fixes and then ready RTBC from me.
- Resolved by Matthieu Scarset
- Resolved by Matthieu Scarset
- Resolved by Matthieu Scarset
(OMG) I realized I didnt submit a comment I made weeks ago...
Anyway, as requested, I have undo the changes I made to
GenerateCommand.php
.I think it is not ideal to ship the starterkit_theme this way because there are too much things to change manually (JS filename, library name...etc) but I understand the point that the script is being rewritten.
In case we change our mind, I'll be more than happy to re-apply my previous changes to make the generate command more helpful for onboarding developers/themers.
added 88 commits
-
2c6293c1...75a15bb8 - 79 commits from branch
project:11.x
- ddb70dcf - Example JS behavior in starterkit_theme #3209192
- 47825190 - Add comment about element selector #3209192
- 92ba0c2d - Fix coding standard #3209192
- 265561fd - Fix coding standard (JS) #3209192
- fea00e31 - Fix typo #3209192
- 36f671dc - More detailed comments #3209192
- ed412948 - Revert changes to GenerateTheme #3209192
- c80436cf - Fix coding standard #3209192
- edf80c30 - fixed typo
Toggle commit list-
2c6293c1...75a15bb8 - 79 commits from branch
- Resolved by Matthieu Scarset
added 1 commit
added 79 commits
-
e882a6c9...3515f040 - 69 commits from branch
project:11.x
- 44ae389b - Example JS behavior in starterkit_theme #3209192
- f8d0877b - Add comment about element selector #3209192
- 4da49d53 - Fix coding standard #3209192
- 2638965c - Fix coding standard (JS) #3209192
- 4af14604 - Fix typo #3209192
- f090448d - More detailed comments #3209192
- 2dcae2cb - Revert changes to GenerateTheme #3209192
- d8eac848 - Fix coding standard #3209192
- 88ad4fb9 - fixed typo
- be14941c - Use Drupal.Message to display reading time #3209192
Toggle commit list-
e882a6c9...3515f040 - 69 commits from branch
added 14 commits
- dae48d4d...78187c3a - 4 earlier commits
- d00505b8 - Issue #3382453 by Wim Leers, smustgrave, borisson_:...
- 5d864073 - Issue #3380480 by phenaproxima, quietone, Wim Leers, lauriii, dww,...
- 9432888e - Issue #2444979 by Wim Leers, webflo, borisson_, catch, Gábor Hojtsy,...
- a604acc0 - Issue #3375592 by catch, longwave: [random test failure] Random failure in...
- 06a3930c - Issue #3381557 by nmangold, lauriii, Wim Leers, joshuami: [DrupalMedia]...
- ef54ee7a - Issue #3329066 by dabblela, quietone, joseph.olstad, smustgrave, catch,...
- 633afbc5 - Issue #3388365 by catch, larowlan, bbrala, smustgrave: Distribute @group #slow...
- d04e9acb - Issue #3386458 by catch, quietone, alexpott, larowlan: Add...
- 62dd4e17 - Issue #3387831 by thakurnishant_06, vbouchet, smustgrave: Fix change record link added in #2914251
- 998f86d0 - Issue #3386058 by welly, bbrala: Update PhpDoc type for Drupal\jsonapi\JsonApiResource\Link::$rel
Toggle commit listadded 25 commits
-
998f86d0...dff46835 - 14 commits from branch
project:11.x
- 657db03c - 1 earlier commit
- fc6e1259 - Add comment about element selector #3209192
- 37b40ec0 - Fix coding standard #3209192
- eed3d4b8 - Fix coding standard (JS) #3209192
- efb78fbe - Fix typo #3209192
- 075a4d61 - More detailed comments #3209192
- c0208482 - Revert changes to GenerateTheme #3209192
- 17c37772 - Fix coding standard #3209192
- 1610b9b7 - fixed typo
- 6e602dba - Use Drupal.Message to display reading time #3209192
- 29bbbcdc - Fix typo #3209192
Toggle commit list-
998f86d0...dff46835 - 14 commits from branch
added 285 commits
-
29bbbcdc...6dc9ce0b - 284 commits from branch
project:11.x
- aa5a3a5a - Merge branch '11.x' into 3209192-starterkit-theme-add
-
29bbbcdc...6dc9ce0b - 284 commits from branch
1 /** 2 * @file 3 * Defines a custom behavior. 4 */ 5 6 (function (Drupal, drupalSettings, once) { changed this line in version 17 of the diff
56 * @see starterkit_theme.libraries.yml 57 * Where dependencies to core/drupalSettings and core/once are defined. 58 * @see https://www.drupal.org/docs/drupal-apis/javascript-api/javascript-api-overview 59 * An introduction to the art of using JavaScript in Drupal. 60 * @see https://www.drupal.org/node/3158256 61 * The change notice with examples of how to use once(). 62 * @see https://www.npmjs.com/package/@drupal/once 63 * The NPM package with the full documentation about once(). 64 */ 65 Drupal.behaviors.readingTime = { 66 attach(context) { 67 // Process the current content to calculate the reading time. 68 // We use `once()` from core to avoid processing the content multiple time. 69 once(onceName, elementSelector, context).forEach((element) => { 70 const time = readingTime(element, wordsPerMinute); 71 messages.add( added 1 commit
- 19a66eea - Updated function declaration to use arrow fun syntax