Skip to content
Snippets Groups Projects

Resolve #3209192 "Starterkit theme add"

Closes #3209192

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline failed for 19a66eea

Code Quality is loading
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthieu Scarset resolved all threads

    resolved all threads

  • Andy Blum
  • Andy Blum
  • Andy Blum
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • (OMG) I realized I didnt submit a comment I made weeks ago...

    Anyway, as requested, I have undo the changes I made to GenerateCommand.php .

    I think it is not ideal to ship the starterkit_theme this way because there are too much things to change manually (JS filename, library name...etc) but I understand the point that the script is being rewritten.

    In case we change our mind, I'll be more than happy to re-apply my previous changes to make the generate command more helpful for onboarding developers/themers.

  • Matthieu Scarset resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 88 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Matthieu Scarset added 79 commits

    added 79 commits

    Compare with previous version

  • Matthieu Scarset resolved all threads

    resolved all threads

  • Matthieu Scarset added 14 commits

    added 14 commits

    Compare with previous version

  • Matthieu Scarset added 25 commits

    added 25 commits

    Compare with previous version

  • Matthieu Scarset added 285 commits

    added 285 commits

    Compare with previous version

  • 1 /**
    2 * @file
    3 * Defines a custom behavior.
    4 */
    5
    6 (function (Drupal, drupalSettings, once) {
  • 56 * @see starterkit_theme.libraries.yml
    57 * Where dependencies to core/drupalSettings and core/once are defined.
    58 * @see https://www.drupal.org/docs/drupal-apis/javascript-api/javascript-api-overview
    59 * An introduction to the art of using JavaScript in Drupal.
    60 * @see https://www.drupal.org/node/3158256
    61 * The change notice with examples of how to use once().
    62 * @see https://www.npmjs.com/package/@drupal/once
    63 * The NPM package with the full documentation about once().
    64 */
    65 Drupal.behaviors.readingTime = {
    66 attach(context) {
    67 // Process the current content to calculate the reading time.
    68 // We use `once()` from core to avoid processing the content multiple time.
    69 once(onceName, elementSelector, context).forEach((element) => {
    70 const time = readingTime(element, wordsPerMinute);
    71 messages.add(
    • Test is failing here. If I remove the messages.add part the test passes.

      The reason this is being triggered in that test is because that test is using the theme "test_messages" which installs starterkit_theme.

    • Please register or sign in to reply
  • Gaurav added 1 commit

    added 1 commit

    • 19a66eea - Updated function declaration to use arrow fun syntax

    Compare with previous version

  • Please register or sign in to reply
    Loading