Issue #2012976: Deprecate user_logout() and user_login_finalize() and replace with a service
Merge request reports
Activity
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
added 4 commits
-
f74d33fa...1debb398 - 3 commits from branch
project:11.x
- 9a425a46 - Adds a UserSessionHandler and deprecates user_login_finalize() and user_logout()
-
f74d33fa...1debb398 - 3 commits from branch
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Kim Pepper
added 48 commits
-
64e72bf2...4e12f074 - 46 commits from branch
project:11.x
- fa1343f5 - Merge branch '11.x' into 2012976-user-session-handler
- f89b833b - Adds deprecation triggers and test
-
64e72bf2...4e12f074 - 46 commits from branch
added 121 commits
-
f89b833b...fe938f57 - 117 commits from branch
project:11.x
- 9212c93b - Adds a UserSessionHandler and deprecates user_login_finalize() and user_logout()
- cb142c69 - Feedback fixes
- 1a2b196c - Fix test
- 87733de7 - Adds deprecation triggers and test
Toggle commit list-
f89b833b...fe938f57 - 117 commits from branch
added 94 commits
-
87733de7...e99bc70d - 90 commits from branch
project:11.x
- fa4c53d6 - Adds a UserSessionHandler and deprecates user_login_finalize() and user_logout()
- d282690b - Feedback fixes
- 37675fba - Fix test
- f8b27d99 - Adds deprecation triggers and test
Toggle commit list-
87733de7...e99bc70d - 90 commits from branch
added 340 commits
-
f8b27d99...2e94575d - 336 commits from branch
project:11.x
- d3669ae2 - Adds a UserSessionHandler and deprecates user_login_finalize() and user_logout()
- 0aa5b052 - Feedback fixes
- 183075dc - Fix test
- feb2632c - Adds deprecation triggers and test
Toggle commit list-
f8b27d99...2e94575d - 336 commits from branch
added 33 commits
-
feb2632c...c980ece6 - 29 commits from branch
project:11.x
- 190b32b7 - Adds a UserSessionHandler and deprecates user_login_finalize() and user_logout()
- 759c7e61 - Feedback fixes
- d423ba5d - Fix test
- 7a9cc573 - Adds deprecation triggers and test
Toggle commit list-
feb2632c...c980ece6 - 29 commits from branch
- Resolved by Kim Pepper
- Resolved by Kim Pepper
- Resolved by Lee Rowlands
- Resolved by Lee Rowlands
- Resolved by Lee Rowlands
- Resolved by Lee Rowlands
- Resolved by Lee Rowlands
- Resolved by Lee Rowlands
added 100 commits
-
99eeeb10...16552b02 - 93 commits from branch
project:11.x
- 4d8b3221 - Adds a UserSessionHandler and deprecates user_login_finalize() and user_logout()
- bc411d2f - Feedback fixes
- 2327163c - Fix test
- c00d7bc7 - Adds deprecation triggers and test
- 492cca89 - Remove UserSessionHandler interface
- a1a84c65 - Replacing 10.2.0 with 10.3.0
- 1c8bb7fa - Update deprecation messages per suggestions
Toggle commit list-
99eeeb10...16552b02 - 93 commits from branch
added 33 commits
-
3abc885f...62498926 - 22 commits from branch
project:11.x
- 10b547aa - 1 earlier commit
- ab271c4f - Feedback fixes
- 46236d8e - Fix test
- a4e6fdce - Adds deprecation triggers and test
- 8d3f97b8 - Remove UserSessionHandler interface
- a9d3551a - Replacing 10.2.0 with 10.3.0
- 8e612202 - Update deprecation messages per suggestions
- f34ae4d3 - Adds missing docs
- 31a4a44e - Rename to Finalizer
- dc2f716b - Rename to finalizer in docs
- 6712186d - Renames test
Toggle commit list-
3abc885f...62498926 - 22 commits from branch
added 20 commits
-
6712186d...945ff69c - 9 commits from branch
project:11.x
- 2978ec6e - 1 earlier commit
- f1c74d3a - Feedback fixes
- 9c6381cd - Fix test
- c1d981a0 - Adds deprecation triggers and test
- 7313908e - Remove UserSessionHandler interface
- 5ebc095f - Replacing 10.2.0 with 10.3.0
- 5eac7499 - Update deprecation messages per suggestions
- 08ec7b5a - Adds missing docs
- e775f56a - Rename to Finalizer
- b30254f3 - Rename to finalizer in docs
- e548faaf - Renames test
Toggle commit list-
6712186d...945ff69c - 9 commits from branch
added 79 commits
-
e548faaf...d3c96ddf - 68 commits from branch
project:11.x
- d3b833ff - 1 earlier commit
- 2ba94f04 - Feedback fixes
- 23fe2a33 - Fix test
- 7675693a - Adds deprecation triggers and test
- 5bd68336 - Remove UserSessionHandler interface
- 2b9cb6db - Replacing 10.2.0 with 10.3.0
- 069c7fae - Update deprecation messages per suggestions
- bcc680f9 - Adds missing docs
- f4cbb57c - Rename to Finalizer
- b4cfb20c - Rename to finalizer in docs
- 593f7fe8 - Renames test
Toggle commit list-
e548faaf...d3c96ddf - 68 commits from branch
added 159 commits
-
593f7fe8...71c9b9f7 - 148 commits from branch
project:11.x
- d19054fb - 1 earlier commit
- 238d83cc - Feedback fixes
- 24208767 - Fix test
- 540cad72 - Adds deprecation triggers and test
- 790ac319 - Remove UserSessionHandler interface
- 19d69795 - Replacing 10.2.0 with 10.3.0
- 708b20d3 - Update deprecation messages per suggestions
- 076b9764 - Adds missing docs
- aa12c758 - Rename to Finalizer
- c346253e - Rename to finalizer in docs
- 4c618517 - Renames test
Toggle commit list-
593f7fe8...71c9b9f7 - 148 commits from branch
63 $this->moduleHandler->invokeAll('user_login', [$user]); 64 } 65 66 /** 67 * Logs the current user out. 68 */ 69 public function finalizeLogout(): void { 70 $this->logger->info('Session closed for %name.', ['%name' => $this->accountProxy->getAccountName()]); 71 72 $this->moduleHandler->invokeAll('user_logout', [$this->accountProxy]); 73 74 // Destroy the current session, and reset $user to the anonymous user. 75 // Note: In Symfony the session is intended to be destroyed with 76 // Session::invalidate(). Regrettably this method is currently broken and 77 // may lead to the creation of spurious session records in the database. 78 // @see https://github.com/symfony/symfony/issues/12375 changed this line in version 20 of the diff
284 284 filemime 285 285 filesystems 286 286 filetransfer 287 finalizer This is a red flag for me. This word is not in the American Dictionaries that are referenced as a source for d.o. It also leads to some odd sounding sentences in comments.
Can we just call the service, 'UserSessionFinalize', in the same why that the access check service is 'AccessCheck' not 'AccessChecker'?
changed this line in version 20 of the diff
22 * Creates a new UserSessionFinalizer. 23 */ 24 public function __construct( 25 protected AccountProxyInterface $accountProxy, 26 protected RequestStack $requestStack, 27 protected SessionManagerInterface $sessionManager, 28 protected EntityTypeManagerInterface $entityTypeManager, 29 protected ModuleHandlerInterface $moduleHandler, 30 protected LoggerInterface $logger, 31 protected TimeInterface $time, 32 ) {} 33 34 /** 35 * Finalizes the login process and logs in a user. 36 * 37 * The function logs in the user, records a watchdog message about the new changed this line in version 20 of the diff
- Resolved by Kim Pepper
added 21 commits
-
4c618517...93b747d5 - 8 commits from branch
project:11.x
- 93b747d5...7463d09c - 3 earlier commits
- c989abdb - Adds deprecation triggers and test
- ddf722e8 - Remove UserSessionHandler interface
- ecf96ff8 - Replacing 10.2.0 with 10.3.0
- 27b60afd - Update deprecation messages per suggestions
- 61e76052 - Adds missing docs
- 7447bd21 - Rename to Finalizer
- 39916290 - Rename to finalizer in docs
- 7cc55cc4 - Renames test
- 378bb959 - minor change to comment
- 2a987db9 - rename UserSessionFinalizer to UserSessionFinalize
Toggle commit list-
4c618517...93b747d5 - 8 commits from branch
15 16 /** 17 * Finalize user sessions. 18 */ 19 final class UserSessionFinalize { 20 21 /** 22 * Creates a new UserSessionFinalize service. 23 */ 24 public function __construct( 25 protected AccountProxyInterface $accountProxy, 26 protected RequestStack $requestStack, 27 protected SessionManagerInterface $sessionManager, 28 protected EntityTypeManagerInterface $entityTypeManager, 29 protected ModuleHandlerInterface $moduleHandler, 30 protected LoggerInterface $logger,
Please register or sign in to reply