Issue #3379091: Make NodeType config entities fully validatable
1 unresolved thread
Merge request reports
Activity
added 2 commits
added 1 commit
-
e5cc02f6 - Default NodeType::
help and ::description to empty strings
-
e5cc02f6 - Default NodeType::
28 28 label: 'Description' 29 constraints: 30 NotNull: [] 29 31 help: 30 32 type: text 31 33 label: 'Explanation or submission guidelines' 34 constraints: 35 NotNull: [] 32 36 new_revision: 33 37 type: boolean 34 38 label: 'Whether a new revision should be created by default' 35 39 preview_mode: 36 40 type: integer 37 41 label: 'Preview before submitting' 42 constraints: 43 NotNull: [] - Comment on lines +29 to +43
These will soon be implied: as soon as https://www.drupal.org/project/drupal/issues/3364109 lands, these lines can be reverted!
-
Did that in the new MR: !5814 (closed)
@phenaproxima: can you please close this MR? I've transfered all your commits
added 7 commits
-
266caf47...1debb398 - 5 commits from branch
project:11.x - a4a87d17 - Merge branch '11.x' into 3379091-make-nodetype-config
- d0d54c1c - Fix a couple of broken tests
-
266caf47...1debb398 - 5 commits from branch
added 150 commits
-
d0d54c1c...cb1e195b - 148 commits from branch
project:11.x - 5ac40b2c - Merge remote-tracking branch 'origin/11.x' into 3379091-make-nodetype-config
- 1f4d04a9 - Merge in #3379091
-
d0d54c1c...cb1e195b - 148 commits from branch
added 1 commit
- 6fcb09a5 - Make empty help null in all node types shipped with core
added 7 commits
-
cc0c5fb0...48b85189 - 6 commits from branch
project:11.x - ccae4f14 - Merge remote-tracking branch 'origin/11.x' into 3379091-make-nodetype-config
-
cc0c5fb0...48b85189 - 6 commits from branch
added 12 commits
-
ccae4f14...3ae80982 - 2 commits from branch
project:11.x - dd711f57 - Merge in #3379091
- eb25b619 - Make preview_mode validatable and add explicit test coverage
- 672cd9fe - Add NotNull check
- 4d370937 - Make help and description non-nullable
-
3718243d - Default NodeType::
help and ::description to empty strings - c9d54837 - Fix node.type.options_insatll_test
- d0ddcbde - Fix a couple of broken tests
- 9ab683c1 - Make help and description nullable, but not blank
- 35408fd1 - Make empty help null in all node types shipped with core
- 4ee03d05 - Same for description
Toggle commit list-
ccae4f14...3ae80982 - 2 commits from branch
added 16 commits
- 4ee03d05...a4a87d17 - 6 earlier commits
- d0d54c1c - Fix a couple of broken tests
- 5ac40b2c - Merge remote-tracking branch 'origin/11.x' into 3379091-make-nodetype-config
- 1f4d04a9 - Merge in #3379091
- 11da9ff3 - Merge remote-tracking branch 'origin/11.x' into 3379091-make-nodetype-config
- b5c7ce6e - Make help and description nullable, but not blank
- 6fcb09a5 - Make empty help null in all node types shipped with core
- cc0c5fb0 - Same for description
- ccae4f14 - Merge remote-tracking branch 'origin/11.x' into 3379091-make-nodetype-config
- c77d2f18 - Add update path to Node, hopefully fixing all tests
- a041e788 - Merge branch '3379091-make-nodetype-config' of...
Toggle commit listadded 8 commits
-
a041e788...3ec60b18 - 4 commits from branch
project:11.x - 3425dc4d - Merge remote-tracking branch 'origin/11.x' into 3379091-make-nodetype-config
- 732ef4b4 - Fix typo
- 4d4123fc - Add explicit update path test coverage
- 9e29c8b0 - Make NodeTypeForm explicitly set NULL for empty description and help
Toggle commit list-
a041e788...3ec60b18 - 4 commits from branch
added 1 commit
- d46b907e - Make the NodeType migration destination set help and description to NULL if empty
mentioned in merge request !5814 (closed)
Please register or sign in to reply