Skip to content
Snippets Groups Projects

Issue #293295: Views ordered list numbers restart at one when pager used

Open Issue #293295: Views ordered list numbers restart at one when pager used
issue/drupal-293295:293295-views-ordered-list into 11.x
1 unresolved thread
Open James Wilson requested to merge issue/drupal-293295:293295-views-ordered-list into 11.x
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/themes/stable9/templates/views/views-view-list.html.twig
23 23 <h3>{{ title }}</h3>
24 24 {% endif %}
25 25
26 <{{ list.type }}{{ list.attributes }}>
26 {% set list_attributes = (list.attributes) ?: create_attribute() %}
27 {% if list.type == 'ol' %}
28 {# Increment ordered list numbers on views paged results. #}
29 {% set start = view.pager.current_page * view.pager.options.items_per_page + 1 %}
30 {% set list_attributes = list_attributes.setAttribute('start', start) %}
31 {% endif %}
32 <{{ list.type }}{{ list_attributes }}>
  • Comment on lines -26 to +32
    Derek Wright
    Derek Wright @dww
    Developer

    I might have lost track of this, but I believe we're not supposed to change templates in "stable9" -- the "stable" implies they're stable and don't change. :sweat_smile: Even for bug fixes. Unless they're very serious (security, accessibility, etc). This doesn't seem to qualify by those standards, so I believe the safer approach is to leave this part of the diff out of the MR.

  • Please register or sign in to reply
Please register or sign in to reply