Skip to content
Snippets Groups Projects

2838474-11.x

Open Rolando Payán Mosqueda requested to merge issue/drupal-2838474:2838474-11.x into 11.x
1 unresolved thread

Closes #2838474

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline passed for 6b0f23d5

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looking good.

    We are throwing new exceptions. Are we checking that calling code is handling them properly now?

  • Alex Pott added 907 commits

    added 907 commits

    Compare with previous version

  • Alex Pott resolved all threads

    resolved all threads

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Dave Long added 1 commit

    added 1 commit

    • 3f62fd6f - Fix deprecation version and docblock.

    Compare with previous version

  • 60 53 * The stream wrapper manager.
    61 54 * @param \Drupal\Core\Site\Settings $settings
    62 55 * The site settings.
    63 * @param \Psr\Log\LoggerInterface $logger
    64 * The file logger channel.
    56 * @param \Psr\Log\LoggerInterface|null $logger
    57 * (optional) The file logger channel.
    65 58 */
    66 public function __construct(StreamWrapperManagerInterface $stream_wrapper_manager, Settings $settings, LoggerInterface $logger) {
    59 public function __construct(StreamWrapperManagerInterface $stream_wrapper_manager, Settings $settings, LoggerInterface $logger = NULL) {
    67 60 $this->streamWrapperManager = $stream_wrapper_manager;
    68 61 $this->settings = $settings;
    69 $this->logger = $logger;
    62 if ($logger) {
    63 @trigger_error('Calling FileSystem::__construct() with the $logger argument is deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. See https://www.drupal.org/node/3071798', E_USER_DEPRECATED);
  • Kim Pepper added 221 commits

    added 221 commits

    Compare with previous version

  • Kim Pepper added 1 commit

    added 1 commit

    • 6b0f23d5 - Remove logger from constructor

    Compare with previous version

  • Please register or sign in to reply
    Loading