Skip to content
Snippets Groups Projects

#3357382: support external JS in SDC libraryOverrides.

Closed #3357382: support external JS in SDC libraryOverrides.
1 unresolved thread
Closed Robert Ngo requested to merge issue/drupal-3357382:3357382-unable-to-override into 11.x
1 unresolved thread

Closes #3357382

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
42 42 $this->assertStringContainsString('dialog.position.js', $output);
43 43 // Ensure that libraryOverrides processes attributes properly.
44 44 $this->assertMatchesRegularExpression('@<script.*src="[^"]*lib-overrides\.js\?v=1[^"]*".*defer.*bar="foo"></script>@', $output);
45 // Ensure that libraryOverrides processes external JS properly.
46 $this->assertMatchesRegularExpression('@<script.*src="https://cdn\.jsdelivr\.net/npm/docson\@2\.1\.0/lib/index\.min\.js"></script>@', $output);
  • I think we need to change the example URL and also cover the case for CSS. I can't believe I missed that in the original report, but it was likely related to lack of sleep :baby:

  • Robert Ngo added 2 commits

    added 2 commits

    • 3e853817 - #3357382: use drupal.org fake-dependencies URL for testing JS lib-overrides.
    • a8928307 - #3357382: ensure that libraryOverrides processes external CSS properly.

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading