most recent patch to gitlab branch

Autocomplete #3076171

added 1 commit

• a7f6c499 - move post-init shimming to shim file

Compare with previous version

added 3 commits

• df911567 - update tests to handle native events
• 4ec8322c - name change in code
• 1360c057 - file rename

Compare with previous version

added 6 commits

• 1360c057...9c9c981f - 5 commits from branch project:9.2.x
• ec45fc42 - Merge branch '9.2.x' of https://git.drupalcode.org/project/drupal into 3076171-provide-a-new

Compare with previous version

added 55 commits

• ec45fc42...4f29fd7f - 52 commits from branch project:9.2.x
• 8ebe7104 - shimmed and nonshimmed can coexist
• 3d0b0d5d - Merge branch '3076171-provide-a-new' of git.drupal.org:issue/drupal-3076171...
• a93dd53a - Merge remote-tracking branch 'origin/9.2.x' into 3076171-provide-a-new

Compare with previous version

added 1 commit

• 585ee286 - custom command fixes

Compare with previous version

added 1 commit

• 0b3df62d - update test docs and adjust shim to facilitate consistient styling

Compare with previous version

added 1 commit

• ac22c19f - fix testAutocompleteOptions()

Compare with previous version

added 70 commits

• ac22c19f...55422cea - 68 commits from branch project:9.2.x
• 37c400ff - Merge remote-tracking branch 'origin/9.2.x' into 3076171-provide-a-new
• 586ae1b2 - move to vendor

Compare with previous version

added 1 commit

• 9c65baaa - reduce dictionary changes

Compare with previous version

Is the change record up to date since it doesn't mention this? If it isn't, could you by any chance update it with the most recent changes to make reviewing the deprecations easier when you have time?

What do you think about showing deprecation warning in PHP for the Form API autocomplete use cases?

This is probably a good idea, but it deviates a bit from the usual deprecation+change pattern as making this property TRUE would be necessary to not trigger the warning, but this is something only needed for Drupal 9. Do you think that would need to be clarified in the warning?

changed this line in version 13 of the diff

I reconsidered and added this THEN re-reconsidered and removed because it's also possible to bypass the shim in templates or preprocessors with the with the data-drupal-10-autocomplete attribute - this is ultimately the attribute that is checked to determine if the shim should be added. So, not using the form API property doesn't necessarily mean the shim is going to be run. This also makes it quite easy to disable the shim for all autocompeltes via preprocess_input

    $variables['attributes']['data-drupal-10-autocomplete'] = TRUE;
  }

added 2 commits

• edadb415 - Fix non-removal of shimmed focus class when focus leaves list. Restructure messages option
• bde11396 - remove no longer needed skip deprecation message

Compare with previous version

added 2 commits

• 0d4c2207 - move shim test util functions to bottom
• 250bf8ff - remove changes to form state error handling that are probably not needed

Compare with previous version

added 1 commit

• 4a3c765a - property rename, eslint tweak

Compare with previous version

added 1 commit

• b83d103c - messages in subproperty doesnt work, change back

Compare with previous version