Skip to content
Snippets Groups Projects

Issue #3347343: Continuation Add Views EntityReference filter to be available for all entity reference fields

Open Issue #3347343: Continuation Add Views EntityReference filter to be available for all entity reference fields
Open Bram Driesen requested to merge issue/drupal-3347343:3347343-11-x into 11.x

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #427426 canceled

Merge request pipeline canceled for 96b573d1

Approval is optional
Code Quality is loading
Ready to merge by members who can write to the target branch.
  • The source branch is 831 commits behind the target branch.
  • 1 commit will be added to 11.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 328 ];
    329 }
    330
    331 /**
    332 * Change the required to conditionally required only to prevent focus errors.
    333 *
    334 * @param array $element
    335 * The form element.
    336 * @param string $sub_handler
    337 * The sub handler to conditionally require the field for.
    338 */
    339 protected function setRequiredViaStatesOnChildren(array &$element, $sub_handler) {
    340 if (isset($element['#required']) && $element['#required']) {
    341 $element['#required'] = FALSE;
    342 $element['#element_validate'][] = [static::class, 'validateRequired'];
    343 // @todo Conditionally required does not work within config handler extra.
  • 357 /**
    358 * Validates that a required field for a sub handler has a value.
    359 *
    360 * @param array $element
    361 * The cardinality form render array.
    362 * @param \Drupal\Core\Form\FormStateInterface $form_state
    363 * The form state.
    364 */
    365 public static function validateRequired(array &$element, FormStateInterface $form_state): void {
    366 if (!empty($element['value'])) {
    367 return;
    368 }
    369
    370 // Config extra handler does not output validation messages and
    371 // closes the modal with no feedback to the user.
    372 // @todo Find or create a core issue and link here.
  • Tavi Toporjinschi added 271 commits

    added 271 commits

    • 1bc7bda7...676c1dad - 264 commits from branch project:11.x
    • 778f1c1b - feat: Re-apply patch to 11.x
    • 1cffd374 - Fix tests.
    • dee511f5 - Issue 3347343: Rename kernel test file and class names - FilterEntityReferenceTest.
    • 9bb42f50 - Fix CSpell fail.
    • 7ba2fed2 - Fix CSpell fail 2.
    • a7428a8f - Do not limit filters available to Content Entities, use EntityTypeInterface instead.
    • b548c183 - Do not limit filters available to Content Entities, use EntityTypeInterface instead 2.

    Compare with previous version

  • Tavi Toporjinschi added 8 commits

    added 8 commits

    • 666f9e98 - 1 commit from branch project:11.x
    • 084afa22 - feat: Re-apply patch to 11.x
    • 7525c4f4 - Fix tests.
    • 25ac40c8 - Issue 3347343: Rename kernel test file and class names - FilterEntityReferenceTest.
    • c078c8c9 - Fix CSpell fail.
    • 69336b9a - Fix CSpell fail 2.
    • 8ccd7f8d - Do not limit filters available to Content Entities, use EntityTypeInterface instead.
    • 208deaa4 - Do not limit filters available to Content Entities, use EntityTypeInterface instead 2.

    Compare with previous version

  • added 1 commit

    • 92d5e698 - Add Tests for Filter of Config Entities References.

    Compare with previous version

  • added 1 commit

    • abadbd5c - Add Tests for Filter of Config Entities References - fix CS.

    Compare with previous version

  • Tavi Toporjinschi added 11 commits

    added 11 commits

    • abadbd5c...76fac09c - 2 commits from branch project:11.x
    • f56ce4d7 - feat: Re-apply patch to 11.x
    • 85387e40 - Fix tests.
    • 4aabdf77 - Issue 3347343: Rename kernel test file and class names - FilterEntityReferenceTest.
    • 51f71692 - Fix CSpell fail.
    • 06c9bf12 - Fix CSpell fail 2.
    • 9e91584a - Do not limit filters available to Content Entities, use EntityTypeInterface instead.
    • 5ffaf3e5 - Do not limit filters available to Content Entities, use EntityTypeInterface instead 2.
    • a140f6d5 - Add Tests for Filter of Config Entities References.
    • 2e7f5f94 - Add Tests for Filter of Config Entities References - fix CS.

    Compare with previous version

  • Tavi Toporjinschi added 160 commits

    added 160 commits

    • 2e7f5f94...b20ec518 - 151 commits from branch project:11.x
    • 9addeb9b - feat: Re-apply patch to 11.x
    • 4699430c - Fix tests.
    • 00af5b55 - Issue 3347343: Rename kernel test file and class names - FilterEntityReferenceTest.
    • b00af2a4 - Fix CSpell fail.
    • 064ed2bd - Fix CSpell fail 2.
    • e5118d11 - Do not limit filters available to Content Entities, use EntityTypeInterface instead.
    • 9741216f - Do not limit filters available to Content Entities, use EntityTypeInterface instead 2.
    • 3dbe61e9 - Add Tests for Filter of Config Entities References.
    • 6de4aeba - Add Tests for Filter of Config Entities References - fix CS.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Tavi Toporjinschi added 11 commits

    added 11 commits

    • 156533fe - 1 commit from branch project:11.x
    • 8067de16 - feat: Re-apply patch to 11.x
    • 8d7bbd25 - Fix tests.
    • 5e6509c0 - Issue 3347343: Rename kernel test file and class names - FilterEntityReferenceTest.
    • 01ec6d84 - Fix CSpell fail.
    • 8021ed66 - Fix CSpell fail 2.
    • 6a5c03ba - Do not limit filters available to Content Entities, use EntityTypeInterface instead.
    • f0b7e9c2 - Do not limit filters available to Content Entities, use EntityTypeInterface instead 2.
    • 9b163881 - Add Tests for Filter of Config Entities References.
    • 6f0c254d - Add Tests for Filter of Config Entities References - fix CS.
    • 617519af - Fix PHPStan.

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading