Issue #3359012: Claro: Modal dialog buttons not aligned in the "Leave preview" dialog.
1 unresolved thread
Merge request reports
Activity
Filter activity
150 const $buttonset = $dialog.parent().find('.ui-dialog-buttonset'); 151 const combinedButtonWidth = 152 $buttonset 153 .find('button') 154 .toArray() 155 .reduce((prior, button) => { 156 return prior + $(button).outerWidth(); 157 }, 0) + 158 Math.ceil( 159 $buttonset.outerWidth() - 160 $buttonset.closest('.ui-dialog-buttonpane').outerWidth(), 161 ) * 162 2; 163 164 if (combinedButtonWidth > $dialog.width()) { 165 $dialog.dialog('option', 'minWidth', combinedButtonWidth); I'm wondering if we should be setting this value even if
minWidth
has been defined inresponse.dialogOptions
? I was first thinking that changing min-width would be non-intrusive because dialog can be expected to be wider than the min-width. However, this also impacts how jQuery UI resizable behaves meaning that it could lead into unexpected behavior change.I'm also wondering if we should make sure that the
minWidth
we're setting is not larger thanmaxWidth
when it's configured?changed this line in version 5 of the diff
added 1 commit
- 53a05a37 - Make sure that combinedButtonWidth is not more than the max width of the dialog
added 1 commit
- 2c47df0a - Confirm minwidth change will not affect maxWidth
added 125 commits
-
2c47df0a...f597d0ec - 122 commits from branch
project:10.1.x
- 90cb5f92 - auto adjust dialog width if buttons are wider than the provided space
- 97e32675 - Make sure that combinedButtonWidth is not more than the max width of the dialog
- c125edc6 - Confirm minwidth change will not affect maxWidth
Toggle commit list-
2c47df0a...f597d0ec - 122 commits from branch
added 234 commits
-
642e97d8...91609efd - 232 commits from branch
project:11.x
- 3f7f4e98 - Add css
- 6ed1a0cb - Apply css from comment #9
-
642e97d8...91609efd - 232 commits from branch
Please register or sign in to reply