Issue #1149078: States API doesn't work with multiple select fields
2 unresolved threads
Merge request reports
Activity
added 1 commit
added 1 commit
added 88 commits
-
f32c8c2f...c49ae937 - 86 commits from branch
project:10.1.x
- 6d7c7a6d - Issue #1149078 by wuinfo, Gauravvvv, Marios Anagnostopoulos, peterpoe,...
- 4a0bcf57 - Issue #1149078: Replaced Object.values with Object.entries for key, value pairs
-
f32c8c2f...c49ae937 - 86 commits from branch
added 1 commit
added 1 commit
added 146 commits
-
1f48b5d9...942722de - 137 commits from branch
project:10.1.x
- e0b65a34 - Issue #1149078 by wuinfo, Gauravvvv, Marios Anagnostopoulos, peterpoe,...
- e4f82d9c - Issue #1149078: Replaced Object.values with Object.entries for key, value pairs
- e68875e6 - Issue #1149078: States API doesn't work with multiple select fields - Add tests.
- a737c47f - Issue #1149078: States API doesn't work with multiple select fields - Change...
- a64d550a - Issue #1149078: States API doesn't work with multiple select fields - Fix tests.
- b411047e - Bug #1149078: Add headers to JavascriptStatesForm to make manual testing + validation easier.
- 8abd768c - Bug #1149078: At end of doMultipleSelectTriggerTests() unset values and re-check initial state.
- b70a16b4 - Bug #1149078: Uncomment failing assertions to see testbot results.
- 3ab7d47c - Bug #1149078: Comment-out failing assertions to see passing test result.
Toggle commit list-
1f48b5d9...942722de - 137 commits from branch
149 149 * 150 150 * @prop {function} RegExp 151 151 * @prop {function} Function 152 152 * @prop {function} Number @larowlan of course ... updated
159 159 // The "reference" variable is a comparison function. 160 160 return reference(value); 161 161 }, 162 Array(reference, value) { 163 // Make sure value is an array. 164 if (!Array.isArray(value)) { 165 return false; 166 } 167 168 // The arrays values should match. 169 return JSON.stringify(reference) === JSON.stringify(value); changed this line in version 9 of the diff
@larowlan indeed ... nice catch ... updated thank you
In relation to the skipped tests, perhaps the style is significant in the underlying isVisible implementation for chromedriver?
Perhaps we could assert the attribute was empty, then use something like executeScript to remove the attribute and see if that makes a difference.
I agree though that it would be better to get this fixed and defer those tests to a follow up.
added 1 commit
added 1 commit
added 1 commit
added 262 commits
-
80ed873d...308e696f - 250 commits from branch
project:10.1.x
- 308e696f...abeb518e - 2 earlier commits
- 5f2c986a - Issue #1149078: States API doesn't work with multiple select fields - Add tests.
- 908e23b4 - Issue #1149078: States API doesn't work with multiple select fields - Change...
- ad0baf24 - Issue #1149078: States API doesn't work with multiple select fields - Fix tests.
- 81e73097 - Bug #1149078: Add headers to JavascriptStatesForm to make manual testing + validation easier.
- 7b2f389f - Bug #1149078: At end of doMultipleSelectTriggerTests() unset values and re-check initial state.
- eddd392c - Bug #1149078: Uncomment failing assertions to see testbot results.
- 51566a3c - Bug #1149078: Comment-out failing assertions to see passing test result.
- 8ec5c8da - Issue #1149078: States API doesn't work with multiple select fields - Fix...
- 3d454a46 - Issue #1149078: States API doesn't work with multiple select fields - Comments updates.
- 4d0be715 - Bug #1149078: Add @see comment pointing to [#3367310]
Toggle commit list-
80ed873d...308e696f - 250 commits from branch
Please register or sign in to reply