Skip to content
Snippets Groups Projects

Issue #2317981: The Breadcrumb for block content entities is not useful

Open Issue #2317981: The Breadcrumb for block content entities is not useful
1 unresolved thread
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
53 67 block_content: \d+
54 68
69 # @todo Deprecate this route once
70 # https://www.drupal.org/project/drupal/issues/3159210 is fixed, or remove
71 # it in Drupal 11.
72 # @see https://www.drupal.org/node/2317981
73 entity.block_content.edit_form.bc:
74 path: '/block/{block_content}'
75 defaults:
76 _controller: '\Drupal\block_content\Controller\BlockContentController::editRedirect'
77 options:
78 _admin_route: TRUE
79 requirements:
80 _entity_access: 'block_content.update'
81 block_content: \d+
82
  • Comment on lines +69 to +82

    Doesn't this duplicate entity.block_content.canoinical.bc - why do we need both?

  • Yes, they are duplicates. So are entity.block_content.edit_form and entity.block_content.canonical.

    I suppose there is some reason for the existing duplicate. There are link templates for the canonical route and for the edit form, and something might go wrong if one of those is missing. That reason does not apply to the BC route.

    This MR uses entity.block_content.edit_form.bc in the redirect controller, so I removed the other one (BC version of the canonical route). Let's see what the testbot thinks.

  • Please register or sign in to reply
  • Benji Fisher added 1 commit

    added 1 commit

    • 5f0c7a31 - Remove duplicate BC redirect route

    Compare with previous version

  • Please register or sign in to reply
    Loading