Skip to content
Snippets Groups Projects

Issue #3347291: Combine field storage and field instance forms

Closed Issue #3347291: Combine field storage and field instance forms
1 unresolved thread
Closed Harumi Jang requested to merge issue/drupal-3347291:3347291-combine-field-storage into 10.1.x
1 unresolved thread

Merge request reports

Closed by Lauri TimmaneeLauri Timmanee 1 year ago (Sep 1, 2023 2:36pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
416 416 public function storageSettingsForm(array &$form, FormStateInterface $form_state, $has_data) {
417 417 $element['target_type'] = [
418 418 '#type' => 'select',
419 '#title' => $this->t('Type of item to reference'),
419 '#title' => $this->t('Type of itemmm to reference'),
420 420 '#default_value' => $this->getSetting('target_type'),
421 421 '#required' => TRUE,
422 422 '#disabled' => $has_data,
423 423 '#size' => 1,
424 '#ajax' => [
  • I think we might need something more generic than this because there are other dependencies between the storage and the field instance. For example, when field cardinality is changed, it should update the field for setting default value field. Probably most of the field storage fields actually have an impact on something in the field instance form.

  • Author Contributor

    Do you mean add a generic ajax callback to every element/setting in the storage settings subform and have the callback decide what fields to update on the field instance form?

  • It should probably work so that changes to any storage settings triggers an update to the whole form :thinking:

  • Harumi Jang changed this line in version 12 of the diff

    changed this line in version 12 of the diff

  • Please register or sign in to reply
  • Harumi Jang added 51 commits

    added 51 commits

    Compare with previous version

  • Harumi Jang added 2 commits

    added 2 commits

    • 61f3f900 - Attach listeners to field storage inputs
    • 0b2f3ebb - Dynamically change handler settings

    Compare with previous version

  • Harumi Jang added 2 commits

    added 2 commits

    Compare with previous version

  • Harumi Jang added 1 commit
  • Harumi Jang added 1 commit

    added 1 commit

    Compare with previous version

  • Harumi Jang added 1 commit

    added 1 commit

    • 1a8ed172 - Process checkboxes manually and adjust ajax replace command

    Compare with previous version

  • Harumi Jang added 1 commit

    added 1 commit

    Compare with previous version

  • Tim Plunkett added 48 commits

    added 48 commits

    Compare with previous version

  • Tim Plunkett added 5 commits

    added 5 commits

    • d5767f2d - Fix mistakes I made
    • 6fbc0c65 - Suppress warnings on Checkboxes::processCheckboxes call
    • 15542554 - Check isRebuilding instead of triggering element
    • c06d4eac - Fix tests
    • 132d3dd0 - Remove obsolete interstitial save call

    Compare with previous version

  • Tim Plunkett added 2 commits

    added 2 commits

    • a7e0e1d8 - Fix last settings[target_type]
    • db73b269 - Fix last FunctionalJavascript failure

    Compare with previous version

  • Tim Plunkett added 43 commits

    added 43 commits

    Compare with previous version

  • Tim Plunkett added 2 commits

    added 2 commits

    • d34ea97c - Try using a specific button to update changes on entityref
    • ab9b1af6 - Persist changes made to triggering elements in #process callbacks

    Compare with previous version

  • Tim Plunkett added 1 commit

    added 1 commit

    • e4fd0cbb - Fix functional entityref tests

    Compare with previous version

  • Tim Plunkett added 1 commit

    added 1 commit

    • 44c8da1c - Only change target for entity ref

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 40 commits

    Compare with previous version

  • Tim Plunkett added 1 commit

    added 1 commit

    • 9cc2b78d - Fix bad conflict resolution on phpstan-baseline

    Compare with previous version

  • added 34 commits

    Compare with previous version

  • added 38 commits

    • 2805f5af...3e7279b0 - 5 commits from branch project:10.1.x
    • 3e7279b0...9dce3721 - 23 earlier commits
    • 9aa134ae - Remove obsolete interstitial save call
    • 98697235 - Fix last settings[target_type]
    • 1b08fbb8 - Fix last FunctionalJavascript failure
    • e849b4b9 - Try using a specific button to update changes on entityref
    • 4ff43703 - Persist changes made to triggering elements in #process callbacks
    • 13013dbc - Fix functional entityref tests
    • c11ef0d6 - Only change target for entity ref
    • 7116c3b3 - Test changes
    • e93f4b95 - Fix bad conflict resolution on phpstan-baseline
    • d4d6a2ee - Removed storage edit form route

    Compare with previous version

  • added 1 commit

    • acb8dcde - Fixed input in case of unlimited cardinality

    Compare with previous version

  • added 36 commits

    • 0a32294b - 1 commit from branch project:10.1.x
    • 0a32294b...cf635c21 - 25 earlier commits
    • 025038de - Fix last FunctionalJavascript failure
    • eb78e90c - Try using a specific button to update changes on entityref
    • 95710fce - Persist changes made to triggering elements in #process callbacks
    • 4b4997b5 - Fix functional entityref tests
    • 4ccf30bc - Only change target for entity ref
    • aecd457d - Test changes
    • 66bfa677 - Fix bad conflict resolution on phpstan-baseline
    • 2946362d - Removed storage edit form route
    • 68369e3a - Fixed input in case of unlimited cardinality
    • d4a256b7 - Removed test condition as per code update

    Compare with previous version

  • added 40 commits

    • d4a256b7...8e474357 - 4 commits from branch project:10.1.x
    • 8e474357...d5932168 - 26 earlier commits
    • ad6142b1 - Try using a specific button to update changes on entityref
    • 8b204753 - Persist changes made to triggering elements in #process callbacks
    • d686017d - Fix functional entityref tests
    • ea75a298 - Only change target for entity ref
    • eabc03c4 - Test changes
    • 65890fef - Fix bad conflict resolution on phpstan-baseline
    • 00e7e0a2 - Removed storage edit form route
    • 87c60942 - Fixed input in case of unlimited cardinality
    • 863b4443 - Removed test condition as per code update
    • edf3129b - Fixed image display test

    Compare with previous version

  • added 40 commits

    Compare with previous version

  • added 48 commits

    Compare with previous version

  • added 1 commit

    • 2922e852 - Removed comented code for test to pass

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading