Issue #3347291: Combine field storage and field instance forms
1 unresolved thread
Merge request reports
Activity
added 1 commit
- 531ce62f - Add hook to add field label to breadcumb on edit field settings form
added 43 commits
-
531ce62f...6ca4984f - 41 commits from branch
project:10.1.x
- 71baec39 - Apply patch from #6
- 30a77cf9 - Add hook to add field label to breadcumb on edit field settings form
-
531ce62f...6ca4984f - 41 commits from branch
added 2 commits
added 12 commits
Toggle commit listadded 21 commits
Toggle commit listadded 37 commits
-
3b87b33d...724c5521 - 28 commits from branch
project:10.1.x
- d8cbd065 - Apply patch from #6
- 4cd35e2c - Add hook to add field label to breadcumb on edit field settings form
- 2f1be8cb - Pass 1
- 63764dd5 - Pass 2
- b7b5e0c3 - Pass 3
- 166f4b7f - Add ajax callback stub
- 6c6b7675 - WIP
- 0c89117c - Add prefix and suffix so callback is called every time
- f44de27d - sort list will work on an ajax refresh
Toggle commit list-
3b87b33d...724c5521 - 28 commits from branch
416 416 public function storageSettingsForm(array &$form, FormStateInterface $form_state, $has_data) { 417 417 $element['target_type'] = [ 418 418 '#type' => 'select', 419 '#title' => $this->t('Type of item to reference'), 419 '#title' => $this->t('Type of itemmm to reference'), 420 420 '#default_value' => $this->getSetting('target_type'), 421 421 '#required' => TRUE, 422 422 '#disabled' => $has_data, 423 423 '#size' => 1, 424 '#ajax' => [ I think we might need something more generic than this because there are other dependencies between the storage and the field instance. For example, when field cardinality is changed, it should update the field for setting default value field. Probably most of the field storage fields actually have an impact on something in the field instance form.
changed this line in version 12 of the diff
added 51 commits
-
f44de27d...bef31d1d - 40 commits from branch
project:10.1.x
- 223bc83a - 1 earlier commit
- 742dda48 - Add hook to add field label to breadcumb on edit field settings form
- 52a38c2f - Pass 1
- 53ef81a5 - Pass 2
- 2e390f92 - Pass 3
- e3c3dd1c - Add ajax callback stub
- 5d4b7208 - WIP
- 2700675f - Add prefix and suffix so callback is called every time
- 1aef46ee - sort list will work on an ajax refresh
- 4220a24e - Remove comments
- cee96de8 - Add placeholder hook
Toggle commit list-
f44de27d...bef31d1d - 40 commits from branch
added 2 commits
added 1 commit
- 1a8ed172 - Process checkboxes manually and adjust ajax replace command
added 48 commits
-
da08edbf...b4d06001 - 29 commits from branch
project:10.1.x
- b4d06001...2a74846a - 9 earlier commits
- 69b24bd4 - Remove comments
- abbb0ad7 - Add placeholder hook
- 44df3756 - Attach listeners to field storage inputs
- 23234100 - Dynamically change handler settings
- afea1ef9 - Allow inner function
- d3ebfc2c - phpcs
- 9757fda3 - phpcs
- 60298349 - add to phpstan-baseline
- fc17d367 - Process checkboxes manually and adjust ajax replace command
- 9e7cd7d7 - Sniff and phpstan
Toggle commit list-
da08edbf...b4d06001 - 29 commits from branch
added 2 commits
added 43 commits
-
db73b269...40a02eb7 - 17 commits from branch
project:10.1.x
- 40a02eb7...a6409c6c - 16 earlier commits
- 1f1031ff - add to phpstan-baseline
- a46b464a - Process checkboxes manually and adjust ajax replace command
- e8f8c6ef - Sniff and phpstan
- 632cd2a6 - Fix mistakes I made
- 9ad13c1e - Suppress warnings on Checkboxes::processCheckboxes call
- cf69c6e8 - Check isRebuilding instead of triggering element
- 2f6b9a75 - Fix tests
- 4d00bf6f - Remove obsolete interstitial save call
- cca0dfe2 - Fix last settings[target_type]
- f54acdca - Fix last FunctionalJavascript failure
Toggle commit list-
db73b269...40a02eb7 - 17 commits from branch
added 40 commits
-
352246c4...f1e19f22 - 9 commits from branch
project:10.1.x
- f1e19f22...8755bba7 - 21 earlier commits
- 244633ab - Check isRebuilding instead of triggering element
- 1a8e6ab5 - Fix tests
- 9a4b2ff8 - Remove obsolete interstitial save call
- 5ff509e5 - Fix last settings[target_type]
- 581ea480 - Fix last FunctionalJavascript failure
- baa8ea82 - Try using a specific button to update changes on entityref
- 8c2afb7b - Persist changes made to triggering elements in #process callbacks
- 40443053 - Fix functional entityref tests
- d45124e0 - Only change target for entity ref
- 063c52a1 - Test changes
Toggle commit list-
352246c4...f1e19f22 - 9 commits from branch
added 1 commit
- 9cc2b78d - Fix bad conflict resolution on phpstan-baseline
added 34 commits
-
9cc2b78d...3bafeb49 - 2 commits from branch
project:10.1.x
- 3bafeb49...18b3a93a - 22 earlier commits
- 23317eda - Fix tests
- 2e853f77 - Remove obsolete interstitial save call
- b1e8efb6 - Fix last settings[target_type]
- bffc8e2e - Fix last FunctionalJavascript failure
- 45b5e2ac - Try using a specific button to update changes on entityref
- 8e7605ce - Persist changes made to triggering elements in #process callbacks
- 759bad51 - Fix functional entityref tests
- b4c62445 - Only change target for entity ref
- 28ec7b3b - Test changes
- 2805f5af - Fix bad conflict resolution on phpstan-baseline
Toggle commit list-
9cc2b78d...3bafeb49 - 2 commits from branch
added 38 commits
-
2805f5af...3e7279b0 - 5 commits from branch
project:10.1.x
- 3e7279b0...9dce3721 - 23 earlier commits
- 9aa134ae - Remove obsolete interstitial save call
- 98697235 - Fix last settings[target_type]
- 1b08fbb8 - Fix last FunctionalJavascript failure
- e849b4b9 - Try using a specific button to update changes on entityref
- 4ff43703 - Persist changes made to triggering elements in #process callbacks
- 13013dbc - Fix functional entityref tests
- c11ef0d6 - Only change target for entity ref
- 7116c3b3 - Test changes
- e93f4b95 - Fix bad conflict resolution on phpstan-baseline
- d4d6a2ee - Removed storage edit form route
Toggle commit list-
2805f5af...3e7279b0 - 5 commits from branch
added 1 commit
- acb8dcde - Fixed input in case of unlimited cardinality
added 36 commits
-
0a32294b - 1 commit from branch
project:10.1.x
- 0a32294b...cf635c21 - 25 earlier commits
- 025038de - Fix last FunctionalJavascript failure
- eb78e90c - Try using a specific button to update changes on entityref
- 95710fce - Persist changes made to triggering elements in #process callbacks
- 4b4997b5 - Fix functional entityref tests
- 4ccf30bc - Only change target for entity ref
- aecd457d - Test changes
- 66bfa677 - Fix bad conflict resolution on phpstan-baseline
- 2946362d - Removed storage edit form route
- 68369e3a - Fixed input in case of unlimited cardinality
- d4a256b7 - Removed test condition as per code update
Toggle commit list-
0a32294b - 1 commit from branch
added 40 commits
-
d4a256b7...8e474357 - 4 commits from branch
project:10.1.x
- 8e474357...d5932168 - 26 earlier commits
- ad6142b1 - Try using a specific button to update changes on entityref
- 8b204753 - Persist changes made to triggering elements in #process callbacks
- d686017d - Fix functional entityref tests
- ea75a298 - Only change target for entity ref
- eabc03c4 - Test changes
- 65890fef - Fix bad conflict resolution on phpstan-baseline
- 00e7e0a2 - Removed storage edit form route
- 87c60942 - Fixed input in case of unlimited cardinality
- 863b4443 - Removed test condition as per code update
- edf3129b - Fixed image display test
Toggle commit list-
d4a256b7...8e474357 - 4 commits from branch
added 40 commits
-
edf3129b...492062df - 3 commits from branch
project:10.1.x
- 492062df...61916a3a - 27 earlier commits
- 41224954 - Persist changes made to triggering elements in #process callbacks
- 51cbfa34 - Fix functional entityref tests
- 5d922502 - Only change target for entity ref
- 98f2e629 - Test changes
- 852aaea6 - Fix bad conflict resolution on phpstan-baseline
- b5a74678 - Removed storage edit form route
- f7b1358e - Fixed input in case of unlimited cardinality
- a4a8a1f9 - Removed test condition as per code update
- 045a8148 - Fixed image display test
- 0219ab85 - Removed processCheckboxes
Toggle commit list-
edf3129b...492062df - 3 commits from branch
added 48 commits
-
0219ab85...53f13043 - 10 commits from branch
project:10.1.x
- 53f13043...7215de0a - 28 earlier commits
- dd6a17f4 - Fix functional entityref tests
- 58e24175 - Only change target for entity ref
- ea25ed03 - Test changes
- 31d7d2a8 - Fix bad conflict resolution on phpstan-baseline
- ea0874b0 - Removed storage edit form route
- c4e97f6e - Fixed input in case of unlimited cardinality
- e306948e - Removed test condition as per code update
- fda11766 - Fixed image display test
- 39e2c879 - Removed processCheckboxes
- 48fe4944 - WIP code to fix issue related to reference
Toggle commit list-
0219ab85...53f13043 - 10 commits from branch
Please register or sign in to reply